Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse box-shadow code for drop-shadow filter #14359

Merged
merged 1 commit into from Dec 14, 2016
Merged

Reuse box-shadow code for drop-shadow filter #14359

merged 1 commit into from Dec 14, 2016

Conversation

@shinglyu
Copy link
Member

shinglyu commented Nov 24, 2016 •
edited by larsbergstrom

Followup for #14218. Extracted the Shadow struct and methods into values::*, and make box-shadow and drop-shadow share the new Shadow type. The ToCss trait is not reused because they behave different in the two properties.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #14219 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Nov 24, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/values/specified/mod.rs, components/style/properties/longhand/effects.mako.rs, components/style/values/computed/mod.rs
  • @emilio: components/style/properties/gecko.mako.rs, components/style/values/specified/mod.rs, components/style/properties/longhand/effects.mako.rs, components/style/values/computed/mod.rs
@highfive
Copy link

highfive commented Nov 24, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@shinglyu
Copy link
Member Author

shinglyu commented Nov 24, 2016

r?@Manishearth
@highfive highfive assigned Manishearth and unassigned jdm Nov 24, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 27, 2016

☔ The latest upstream changes (presumably #14373) made this pull request unmergeable. Please resolve the merge conflicts.
@shinglyu shinglyu force-pushed the shinglyu:dropshadow-refactor branch from 00eceed to dd198c7 Nov 28, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Dec 2, 2016

☔ The latest upstream changes (presumably #14370) made this pull request unmergeable. Please resolve the merge conflicts.
@shinglyu
Reuse box-shadow code for drop-shadow filter
Loading status checks…
64ecb33
@shinglyu shinglyu force-pushed the shinglyu:dropshadow-refactor branch from dd198c7 to 64ecb33 Dec 13, 2016
@shinglyu
Copy link
Member Author

shinglyu commented Dec 13, 2016

@Manishearth review ping
@Manishearth
Copy link
Member

Manishearth commented Dec 13, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

📌 Commit 64ecb33 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

⌛ Testing commit 64ecb33 with merge 5bad369...
bors-servo added a commit that referenced this pull request Dec 13, 2016
@bors-servo
Auto merge of #14359 - shinglyu:dropshadow-refactor, r=Manishearth
Loading status checks…
5bad369 
Reuse box-shadow code for drop-shadow filter

<!-- Please describe your changes on the following line: -->

Followup for #14218. Extracted the `Shadow` struct and methods into `values::*`, and make `box-shadow` and `drop-shadow` share the new `Shadow` type. The `ToCss` trait is not reused because they behave different in the two properties.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14219  (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14359)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

💔 Test failed - linux-rel-wpt
@Manishearth
Copy link
Member

Manishearth commented Dec 13, 2016

@bors-servo retry

  • buildbot infra fail
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

⌛ Testing commit 64ecb33 with merge b93bdbb...
bors-servo added a commit that referenced this pull request Dec 13, 2016
@bors-servo
Auto merge of #14359 - shinglyu:dropshadow-refactor, r=Manishearth
Loading status checks…
b93bdbb 
Reuse box-shadow code for drop-shadow filter

<!-- Please describe your changes on the following line: -->

Followup for #14218. Extracted the `Shadow` struct and methods into `values::*`, and make `box-shadow` and `drop-shadow` share the new `Shadow` type. The `ToCss` trait is not reused because they behave different in the two properties.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14219  (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14359)
<!-- Reviewable:end -->
@KiChjang
Copy link
Member

KiChjang commented Dec 14, 2016

@bors-servo retry

  • git gud
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

⌛ Testing commit 64ecb33 with merge 71baf4b...
bors-servo added a commit that referenced this pull request Dec 14, 2016
@bors-servo
Auto merge of #14359 - shinglyu:dropshadow-refactor, r=Manishearth
Loading status checks…
71baf4b 
Reuse box-shadow code for drop-shadow filter

<!-- Please describe your changes on the following line: -->

Followup for #14218. Extracted the `Shadow` struct and methods into `values::*`, and make `box-shadow` and `drop-shadow` share the new `Shadow` type. The `ToCss` trait is not reused because they behave different in the two properties.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14219  (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14359)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

💔 Test failed - mac-rel-wpt2
@KiChjang
Copy link
Member

KiChjang commented Dec 14, 2016

@bors-servo retry

  • git gud
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

⌛ Testing commit 64ecb33 with merge 3754781...
bors-servo added a commit that referenced this pull request Dec 14, 2016
@bors-servo
Auto merge of #14359 - shinglyu:dropshadow-refactor, r=Manishearth
Loading status checks…
3754781 
Reuse box-shadow code for drop-shadow filter

<!-- Please describe your changes on the following line: -->

Followup for #14218. Extracted the `Shadow` struct and methods into `values::*`, and make `box-shadow` and `drop-shadow` share the new `Shadow` type. The `ToCss` trait is not reused because they behave different in the two properties.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14219  (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14359)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

💔 Test failed - mac-rel-wpt2
@KiChjang
Copy link
Member

KiChjang commented Dec 14, 2016

@bors-servo retry

  • git gud
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

⌛ Testing commit 64ecb33 with merge cd1d5f1...
bors-servo added a commit that referenced this pull request Dec 14, 2016
@bors-servo
Auto merge of #14359 - shinglyu:dropshadow-refactor, r=Manishearth
Loading status checks…
cd1d5f1 
Reuse box-shadow code for drop-shadow filter

<!-- Please describe your changes on the following line: -->

Followup for #14218. Extracted the `Shadow` struct and methods into `values::*`, and make `box-shadow` and `drop-shadow` share the new `Shadow` type. The `ToCss` trait is not reused because they behave different in the two properties.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14219  (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14359)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

💔 Test failed - mac-dev-unit
@KiChjang
Copy link
Member

KiChjang commented Dec 14, 2016

@bors-servo retry

  • git gud
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only mac-dev-unit...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 64ecb33 into servo:master Dec 14, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

[Refactor] Reuse the box-shadow parser for CSS filter drop-shadow
7 participants
@shinglyu @highfive @bors-servo @Manishearth @larsbergstrom @KiChjang @jdm
You can’t perform that action at this time.