Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the legacy networking stack. #14360

Merged
merged 9 commits into from Nov 24, 2016
Merged

Remove the legacy networking stack. #14360

merged 9 commits into from Nov 24, 2016
+43 −1,320

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 24, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 9 commits Nov 3, 2016
@Ms2ger
Properly exit the core resource thread.
15e8f4f
@Ms2ger
Remove a test for the CoreResourceMsg::Cancel message.
ce24edc
@Ms2ger
Remove CoreResourceMsg::Load.
fb1279e 
Also remove now-dead code that rustc warns about.

It turns out that we lost support for some of our custom URL schemes; I intend
to reimplement them, but I believe this will be significantly easier to do
once the legacy code is out of the way.
@Ms2ger
Remove unused CancellationListener argument to obtain_response.
ffc2e09
@Ms2ger
Remove unused LoadData and LoadOrigin types.
d6db049
@Ms2ger
Remove unused UIProvider trait definition.
5febfdc
@Ms2ger
Remove the unused CancellationListener arguments in filemanager_thread.
7913f3a
@Ms2ger
Remove unused CancellableResource and CancellationListener types.
69f8564
@Ms2ger
Remove some unused arguments.
Loading status checks…
761524c 
The change to the unit test is necessary because the resource thread is not
resilient against either of these Senders being dropped while the resource
thread is running. Before this change, it held clones of those senders itself
(public_setup_chan_clone, private_setup_chan_clone).
@highfive
Copy link

highfive commented Nov 24, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/xmlhttprequest.rs, components/script_traits/lib.rs, components/script_traits/lib.rs
  • @KiChjang: components/net/Cargo.toml, components/net/about_loader.rs, components/net/fetch/methods.rs, components/net/chrome_loader.rs, components/net/resource_thread.rs, components/net/lib.rs, components/net/data_loader.rs, components/net/file_loader.rs, components/net/http_loader.rs, components/script/dom/xmlhttprequest.rs, components/net/blob_loader.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script_traits/lib.rs, components/script_traits/lib.rs, components/net/filemanager_thread.rs
@nox
Copy link
Member

nox commented Nov 24, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

📌 Commit 761524c has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

⌛ Testing commit 761524c with merge 1321c07...
bors-servo added a commit that referenced this pull request Nov 24, 2016
@bors-servo
Auto merge of #14360 - servo:fetch, r=nox
Loading status checks…
1321c07 
Remove the legacy networking stack.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14360)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

💔 Test failed - mac-rel-wpt2
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Nov 24, 2016

@bors-servo retry # #14323
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, windows-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 24, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 761524c into master Nov 24, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
dependency-ci Checking Dependencies
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the fetch branch Nov 24, 2016
@Ms2ger Ms2ger mentioned this pull request Nov 24, 2016
Closed
31 of 31 tasks complete
@jdm
jdm reviewed Nov 24, 2016
View changes
components/net/http_loader.rs
@@ -535,33 +397,6 @@ pub fn set_cookies_from_headers(url: &ServoUrl, headers: &Headers, cookie_jar: &
}
}

fn update_sts_list_from_response(url: &ServoUrl, response: &HttpResponse, hsts_list: &Arc<RwLock<HstsList>>) {

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Nov 24, 2016

Member

Let's at least file an issue about reimplementing STS for fetch.

This comment has been minimized.

Sign in to view
Copy link
@Ms2ger

Ms2ger Nov 24, 2016

Author Contributor

#14363
components/net/http_loader.rs
}
}

fn set_auth_header(headers: &mut Headers,

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Nov 24, 2016

Member

Let's file an issue about reimplementing HTTP auth for fetch.

This comment has been minimized.

Sign in to view
Copy link
@Ms2ger

Ms2ger Nov 24, 2016

Author Contributor

#14305
@ferjm ferjm mentioned this pull request Mar 6, 2017
Closed
3 of 4 tasks complete
@Darkspirit Darkspirit mentioned this pull request Dec 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees

@nox nox

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @nox @bors-servo @jdm
You can’t perform that action at this time.