Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the http_loader code. #14362

Merged
merged 14 commits into from Nov 26, 2016
Merged

Simplify the http_loader code. #14362

merged 14 commits into from Nov 26, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Nov 24, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 13 commits Nov 21, 2016
@Ms2ger
Use more specific names for Hyper's Request/Response types in http_lo…
6219105 
…ader.
@Ms2ger
Use url::Origin as UrlOrigin in http_loader.
74ea269
@Ms2ger
Unify ReadResult and Data.
675d8f5
@Ms2ger
Move the http-specific fetch code to http_loader.
38db554
@Ms2ger
Remove the HttpRequestFactory trait.
fc6fa56
@Ms2ger
Remove the HttpRequest trait.
87fd4a2
@Ms2ger
Remove the HttpResponse trait.
f24be9a
@Ms2ger
Avoid some unnecessary Options in http_network_fetch.
d9947cd
@Ms2ger
Remove StreamedResponse::metadata.
4d9f9fe
@Ms2ger
Remove StreamedResponse::new().
c20d647
@Ms2ger
Return an io::Result from StreamedResponse::from_http_response().
47fa025
@Ms2ger
Simplify obtain_response() a little.
53856bf
@Ms2ger
Inline WrappedHttpRequest::send().
04d5f6e
@highfive
Copy link

highfive commented Nov 24, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/fetch/methods.rs, components/net/http_loader.rs
@highfive
Copy link

highfive commented Nov 24, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@Ms2ger Ms2ger mentioned this pull request Nov 24, 2016
Closed
31 of 31 tasks complete
@Ms2ger
Remove WrappedHttpRequest.
Loading status checks…
7192a74
@Ms2ger Ms2ger force-pushed the fetch-http-move branch from a33ec00 to 7192a74 Nov 24, 2016
@wafflespeanut
Copy link
Member

wafflespeanut commented Nov 26, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2016

📌 Commit 7192a74 has been approved by Wafflespeanut
@highfive highfive assigned wafflespeanut and unassigned SimonSapin Nov 26, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2016

⌛ Testing commit 7192a74 with merge a093b56...
bors-servo added a commit that referenced this pull request Nov 26, 2016
@bors-servo
Auto merge of #14362 - servo:fetch-http-move, r=Wafflespeanut
Loading status checks…
a093b56 
Simplify the http_loader code.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14362)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 26, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 7192a74 into master Nov 26, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the fetch-http-move branch Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @wafflespeanut @bors-servo @SimonSapin
You can’t perform that action at this time.