Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XPCOM string bindings instead of Gecko_Utf8SliceToString #14404

Merged
merged 1 commit into from Dec 1, 2016
Merged

Use XPCOM string bindings instead of Gecko_Utf8SliceToString #14404

merged 1 commit into from Dec 1, 2016
+3 −14

Conversation

@BorisChiou
Copy link
Contributor

BorisChiou commented Nov 29, 2016 •
edited by larsbergstrom

These are the servo-side changes for bug 1317179. @Manishearth has already reviewed them there. I'd like to merge these patches until the gecko-side changes for bug 1317179 is landed.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix bug 1317179.
  • These changes do not require tests because there are existing tests for this in mozilla-central

This change is Reviewable
@highfive
Copy link

highfive commented Nov 29, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, ports/geckolib/glue.rs
@highfive
Copy link

highfive commented Nov 29, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@BorisChiou BorisChiou force-pushed the BorisChiou:Bug1317179 branch from cb25054 to c6c0769 Nov 29, 2016
@BorisChiou
Bug 1317179 - Use XPCOM string bindings instead of Gecko_Utf8SliceToS…
Loading status checks…
c45bc93 
…tring. r=manishearth
@BorisChiou BorisChiou force-pushed the BorisChiou:Bug1317179 branch from c6c0769 to c45bc93 Nov 29, 2016
@jdm
Copy link
Member

jdm commented Nov 29, 2016

r? @Manishearth
@highfive highfive assigned Manishearth and unassigned jdm Nov 29, 2016
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Nov 29, 2016 •
edited

The gecko-side changes of Bug 1317179 is in m-c now, so we can merge this.
@heycam
Copy link
Member

heycam commented Nov 30, 2016

@bors-servo delegate=BorisChiou
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

✌️ @BorisChiou can now approve this pull request
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Nov 30, 2016

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

📌 Commit c45bc93 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

⌛ Testing commit c45bc93 with merge b8ac79e...
bors-servo added a commit that referenced this pull request Nov 30, 2016
@bors-servo
Auto merge of #14404 - BorisChiou:Bug1317179, r=Manishearth
Loading status checks…
b8ac79e 
Use XPCOM string bindings instead of Gecko_Utf8SliceToString

These are the servo-side changes for [bug 1317179](https://bugzilla.mozilla.org/show_bug.cgi?id=1317179). @Manishearth has already reviewed them there. I'd like to merge these patches until the gecko-side changes for [bug 1317179](https://bugzilla.mozilla.org/show_bug.cgi?id=1317179) is landed.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [bug 1317179](https://bugzilla.mozilla.org/show_bug.cgi?id=1317179).
- [X] These changes do not require tests because there are existing tests for this in mozilla-central

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14404)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

💔 Test failed - android
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Nov 30, 2016

@bors-servo r=Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #14420
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

📌 Commit c45bc93 has been approved by Manishearth
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Nov 30, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only android, linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

💔 Test failed - android
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Nov 30, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only android, linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

💔 Test failed - android
@BorisChiou
Copy link
Contributor Author

BorisChiou commented Dec 1, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2016

⌛ Testing commit c45bc93 with merge 22c8df1...
bors-servo added a commit that referenced this pull request Dec 1, 2016
@bors-servo
Auto merge of #14404 - BorisChiou:Bug1317179, r=Manishearth
Loading status checks…
22c8df1 
Use XPCOM string bindings instead of Gecko_Utf8SliceToString

These are the servo-side changes for [bug 1317179](https://bugzilla.mozilla.org/show_bug.cgi?id=1317179). @Manishearth has already reviewed them there. I'd like to merge these patches until the gecko-side changes for [bug 1317179](https://bugzilla.mozilla.org/show_bug.cgi?id=1317179) is landed.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [bug 1317179](https://bugzilla.mozilla.org/show_bug.cgi?id=1317179).
- [X] These changes do not require tests because there are existing tests for this in mozilla-central

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14404)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit c45bc93 into servo:master Dec 1, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Dec 1, 2016
Merged
0 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@BorisChiou @highfive @jdm @heycam @bors-servo @Manishearth
You can’t perform that action at this time.