Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add insertRule/deleteRule support for stylo #14406

Merged
merged 1 commit into from Dec 1, 2016
Merged

Add insertRule/deleteRule support for stylo #14406

merged 1 commit into from Dec 1, 2016

Conversation

@upsuper
Copy link
Member

upsuper commented Nov 29, 2016 •
edited by larsbergstrom

This is the servo part of bug 1313293, reviewed by @heycam.

r? @heycam

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Nov 29, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko/conversions.rs, components/style/binding_tools/regen.py
  • @emilio: components/style/gecko_bindings/bindings.rs, ports/geckolib/glue.rs, components/style/gecko/conversions.rs, components/style/binding_tools/regen.py
@highfive
Copy link

highfive commented Nov 29, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper upsuper force-pushed the upsuper-forks:bug1313293 branch from f95609b to 43995e3 Nov 29, 2016
@heycam
Copy link
Member

heycam commented Nov 30, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

📌 Commit 43995e3 has been approved by heycam
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

⌛ Testing commit 43995e3 with merge e776bc0...
bors-servo added a commit that referenced this pull request Nov 30, 2016
@bors-servo
Auto merge of #14406 - upsuper:bug1313293, r=heycam
Loading status checks…
e776bc0 
Add insertRule/deleteRule support for stylo

<!-- Please describe your changes on the following line: -->
This is the servo part of [bug 1313293](https://bugzilla.mozilla.org/show_bug.cgi?id=1313293), reviewed by @heycam.

r? @heycam

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14406)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

💔 Test failed - android
@upsuper
Copy link
Member Author

upsuper commented Nov 30, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

⚡ Previous build results for arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only android, linux-rel-wpt...
@bors-servo
Copy link
Contributor

bors-servo commented Nov 30, 2016

💔 Test failed - android
@upsuper
Copy link
Member Author

upsuper commented Dec 1, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2016

🔒 Merge conflict
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2016

☔ The latest upstream changes (presumably #14404) made this pull request unmergeable. Please resolve the merge conflicts.
@upsuper
Add insertRule/deleteRule support for stylo
Loading status checks…
bddd467
@upsuper upsuper force-pushed the upsuper-forks:bug1313293 branch from 43995e3 to bddd467 Dec 1, 2016
@upsuper
Copy link
Member Author

upsuper commented Dec 1, 2016

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2016

🔑 Insufficient privileges
@heycam
Copy link
Member

heycam commented Dec 1, 2016

@bors-servo delegate+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2016

✌️ @upsuper can now approve this pull request
@upsuper
Copy link
Member Author

upsuper commented Dec 1, 2016

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2016

📌 Commit bddd467 has been approved by heycam
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2016

⌛ Testing commit bddd467 with merge 87f5b87...
bors-servo added a commit that referenced this pull request Dec 1, 2016
@bors-servo
Auto merge of #14406 - upsuper:bug1313293, r=heycam
Loading status checks…
87f5b87 
Add insertRule/deleteRule support for stylo

<!-- Please describe your changes on the following line: -->
This is the servo part of [bug 1313293](https://bugzilla.mozilla.org/show_bug.cgi?id=1313293), reviewed by @heycam.

r? @heycam

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14406)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 1, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit bddd467 into servo:master Dec 1, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@upsuper upsuper deleted the upsuper-forks:bug1313293 branch Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@upsuper @highfive @heycam @bors-servo
You can’t perform that action at this time.