Made http_redirect_fetch error for non-HTTPS. #14069

servo · bors-servo · Dec 1, 2016 · Nov 30, 2016 · Nov 30, 2016 · 52194c01d5fc77012bfe06a2c6383da65882196f
commit 52194c01d5fc77012bfe06a2c6383da65882196f
diff --git a/components/net/http_loader.rs b/components/net/http_loader.rs
@@ -772,7 +772,10 @@ fn http_redirect_fetch(request: Rc<Request>,
     };
 
     // Step 4
-    // TODO implement return network_error if not HTTP(S)
+    match location_url.scheme() {
+        "http" | "https" => { },
+        _ => return Response::network_error(NetworkError::Internal("Not an HTTP(S) Scheme".into()))
+    }
 
     // Step 5
     if request.redirect_count.get() >= 20 {

diff --git a/tests/wpt/metadata/fetch/api/redirect/redirect-schemes.html.ini b/tests/wpt/metadata/fetch/api/redirect/redirect-schemes.html.ini
diff --git a/tests/wpt/metadata/fetch/api/redirect/redirect-to-dataurl-worker.html.ini b/tests/wpt/metadata/fetch/api/redirect/redirect-to-dataurl-worker.html.ini
diff --git a/tests/wpt/metadata/fetch/api/redirect/redirect-to-dataurl.html.ini b/tests/wpt/metadata/fetch/api/redirect/redirect-to-dataurl.html.ini