Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upProof of concept: parameterized node traversal methods. #14451
Conversation
highfive
commented
Dec 3, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Dec 3, 2016
|
I've had this sitting around in a branch for a while, thought I might as well open a PR. There's still a little more work to do here, but I didn't want to spend any more time on it if the idea is not well received. |
|
I'm in favour! |
|
Can we use default type parameters yet? |
I thought about making it |
| @@ -2,6 +2,8 @@ | |||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | |||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| #![allow(unrooted_must_root)] | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
frewsxcv
Dec 6, 2016
Author
Member
What? This isn't a wanted improvement? :)
But actually, this is just temporary until I can figure out why the lint is complaining about the iterator structure being unrooted
|
|
|
Ping? |
|
I don't have much time right now to finish this up. If someone else wants to, go for it :) |
|
Tracking this work in #15270. |
frewsxcv commentedDec 3, 2016
•
edited by larsbergstrom
This change is