Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix current_dom_depth in sequential traversal. (fixes #14414) #14459
Conversation
highfive
commented
Dec 5, 2016
highfive
commented
Dec 5, 2016
|
|
|
Oh, of course... @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 5, 2016
Fix current_dom_depth in sequential traversal. (fixes #14414) <!-- Please describe your changes on the following line: --> Since we pass around a reference to the one `PerLevelTraversalData` object in sequential traversal, we must update it after we process children. Alternatively, we could switch to what the parallel traversal is doing and clone the object when passing it down. r? @emilio --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14414 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14459) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
heycam commentedDec 5, 2016
•
edited by larsbergstrom
Since we pass around a reference to the one
PerLevelTraversalDataobject in sequential traversal, we must update it after we process children. Alternatively, we could switch to what the parallel traversal is doing and clone the object when passing it down.r? @emilio
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is