Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the fetch target non-optional. #14465

Merged
merged 9 commits into from Dec 15, 2016
Merged

Make the fetch target non-optional. #14465

merged 9 commits into from Dec 15, 2016
+120 −142

Commits on Dec 15, 2016

  1. Avoid unlocking the response body while it is in an inconsistent state.

    @Ms2ger
    Ms2ger committed Dec 15, 2016
    8a4a5c0

  2. Qualify the fetch() calls in unit tests.

    @Ms2ger
    Ms2ger committed Dec 15, 2016
    8d34ef1

  3. Introduce fetch_with_context() to reduce repetition.

    @Ms2ger
    Ms2ger committed Dec 15, 2016
    9d9f048

  4. Replace fetch_async() by a new fetch() function. 

    fetch() returns immediately after processing EOF, at the latest, so not
spinning up a thread should not cause noticeable delays. OTOH, it might
reduce the contention for cores, and reduce the overall time needed.
    @Ms2ger
    Ms2ger committed Dec 15, 2016
    c03cd45

  5. Use the asynchronous fetching code in unit tests. 

    This is the only code that is used in Servo proper, so it's a more useful
thing to test.
    @Ms2ger
    Ms2ger committed Dec 15, 2016
    a5efc01

  6. Use the asynchronous fetching code for fetch_with_context().

    @Ms2ger
    Ms2ger committed Dec 15, 2016
    306905a

  7. Introduce fetch_with_cors_cache() API for tests.

    @Ms2ger
    Ms2ger committed Dec 15, 2016
    6f2606c

  8. Make the fetch target non-optional.

    @Ms2ger
    Ms2ger committed Dec 15, 2016
    217f44b

  9. Stop returning the response from fetch().

    @Ms2ger
    Ms2ger committed Dec 15, 2016
    Loading status checks…
    1e0ab08
You can’t perform that action at this time.