Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Support remaining display property values. #14467

Merged
merged 3 commits into from Dec 6, 2016

Conversation

@heycam
Copy link
Member

commented Dec 6, 2016

This has already been reviewed by Manish in https://bugzilla.mozilla.org/show_bug.cgi?id=1322185.


This change is Reviewable

heycam added 3 commits Dec 5, 2016
Support declaring keyword property Gecko coverage as inexhaustive.
This allows us to control whether the catchall case in the match expression
that maps Gecko const to Servo enum will be generated.

MozReview-Commit-ID: L65IjTONdfl
stylo: Support remaining display property values.
MozReview-Commit-ID: HjLu7t2g7gF
@highfive

This comment has been minimized.

Copy link

commented Dec 6, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/gecko_bindings/structs_debug.rs, components/style/properties/data.py, components/style/properties/longhand/pointing.mako.rs, components/style/gecko_bindings/structs_release.rs, components/style/properties/longhand/ui.mako.rs, components/style/properties/longhand/xul.mako.rs, components/style/properties/helpers.mako.rs, components/style/properties/longhand/border.mako.rs, components/style/properties/longhand/box.mako.rs, components/style/properties/longhand/inherited_svg.mako.rs
  • @emilio: components/style/properties/gecko.mako.rs, components/style/gecko_bindings/structs_debug.rs, components/style/properties/data.py, components/style/properties/longhand/pointing.mako.rs, components/style/gecko_bindings/structs_release.rs, components/style/properties/longhand/ui.mako.rs, components/style/properties/longhand/xul.mako.rs, components/style/properties/helpers.mako.rs, components/style/properties/longhand/border.mako.rs, components/style/properties/longhand/box.mako.rs, components/style/properties/longhand/inherited_svg.mako.rs
@highfive

This comment has been minimized.

Copy link

commented Dec 6, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@heycam

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2016

@bors-servo r=Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2016

📌 Commit 0bc711b has been approved by Manishearth

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2016

⌛️ Testing commit 0bc711b with merge e11441b...

bors-servo added a commit that referenced this pull request Dec 6, 2016
Auto merge of #14467 - heycam:gecko-display, r=Manishearth
stylo: Support remaining display property values.

<!-- Please describe your changes on the following line: -->

This has already been reviewed by Manish in https://bugzilla.mozilla.org/show_bug.cgi?id=1322185.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2016

@bors-servo bors-servo merged commit 0bc711b into servo:master Dec 6, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.