Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump rust-openssl, add support for OpenSSL 1.1.0 [WIP] #14484
Closed
Conversation
highfive
commented
Dec 7, 2016
|
Heads up! This PR modifies the following files:
|
components/net/connector.rs
Outdated
| let ssl_context_builder = ssl_connector_builder.builder_mut(); | ||
| ssl_context_builder.set_ca_file(ca_file).expect("could not set CA file"); | ||
| ssl_context_builder.set_cipher_list(DEFAULT_CIPHERS).expect("could not set ciphers"); | ||
| ssl_context_builder.set_options(SSL_OP_NO_SSLV2 | SSL_OP_NO_SSLV3 | SSL_OP_NO_COMPRESSION); |
This comment has been minimized.
This comment has been minimized.
sfackler
Dec 8, 2016
These are all set already by the connector fyi: https://github.com/sfackler/rust-openssl/blob/master/openssl/src/ssl/connector.rs#L29
|
|
|
@bors-servo try |
|
|
|
i'm working on rebasing and updating this |
|
@avadacatavra a few updates which may help you
[edit: said webdriver package but meant websocket, updated comment directly] |
|
Not much point in leaving this open. @avadacatavra will open a new PR, presumably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
frewsxcv commentedDec 7, 2016
•
edited
Fixes #14203.
TODO:
This change is