Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filtering in main fetch to the specification. #14515

Closed
wants to merge 1 commit into from
Closed

Update filtering in main fetch to the specification. #14515

wants to merge 1 commit into from

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 9, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Dec 9, 2016

Heads up! This PR modifies the following files:
@frewsxcv
Copy link
Member

frewsxcv commented Dec 9, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2016

📌 Commit 54c3ed3 has been approved by frewsxcv
@highfive highfive assigned frewsxcv and unassigned mbrubeck Dec 9, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2016

⌛ Testing commit 54c3ed3 with merge f3baf5e...
bors-servo added a commit that referenced this pull request Dec 9, 2016
@bors-servo
Auto merge of #14515 - servo:opaque, r=frewsxcv
Loading status checks…
f3baf5e 
Update filtering in main fetch to the specification.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14515)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2016

💔 Test failed - mac-rel-wpt1
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 9, 2016 


  ▶ Unexpected subtest result in /eventsource/dedicated-worker/eventsource-constructor-non-same-origin.htm:
  │ FAIL [expected PASS] dedicated worker - EventSource: constructor (act as if there is a network error) (about:blank)
  │   → assert_equals: source.readyState expected 2 but got 0
  │ 
  │ fetchFail/</worker.onmessage/<@http://web-platform.test:8000/eventsource/dedicated-worker/eventsource-constructor-non-same-origin.htm:9:15
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  └ fetchFail/</worker.onmessage@http://web-platform.test:8000/eventsource/dedicated-worker/eventsource-constructor-non-same-origin.htm:7:13

  ▶ Unexpected subtest result in /eventsource/eventsource-constructor-non-same-origin.htm:
  │ FAIL [expected PASS] EventSource: constructor (act as if there is a network error) (about:blank)
  │   → assert_equals: expected 2 but got 0
  │ 
  │ fetchFail/</source.onerror/<@http://web-platform.test:8000/eventsource/eventsource-constructor-non-same-origin.htm:8:15
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  └ fetchFail/</source.onerror@http://web-platform.test:8000/eventsource/eventsource-constructor-non-same-origin.htm:7:13

Interesting.
@Ms2ger
Update filtering in main fetch to the specification.
Loading status checks…
d6ff488
@Ms2ger Ms2ger force-pushed the opaque branch from 54c3ed3 to 334d804 Dec 9, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 9, 2016

CC @KiChjang
@jdm
Copy link
Member

jdm commented Dec 9, 2016

First commit is fine; let's drop the second commit and I'll file an issue in web-platform-tests.
@Ms2ger Ms2ger force-pushed the opaque branch from 334d804 to d6ff488 Dec 9, 2016
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 9, 2016

@bors-servo r=frewsxcv
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2016

📌 Commit d6ff488 has been approved by frewsxcv
@jdm
Copy link
Member

jdm commented Dec 9, 2016

Filed web-platform-tests/wpt#4311.
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 9, 2016

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2016

⌛ Testing commit d6ff488 with merge 691e77b...
bors-servo added a commit that referenced this pull request Dec 9, 2016
@bors-servo
Auto merge of #14515 - servo:opaque, r=frewsxcv
Loading status checks…
691e77b 
Update filtering in main fetch to the specification.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14515)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2016

💔 Test failed - linux-rel-css
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 9, 2016

@bors-servo retry
???
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2016

⌛ Testing commit d6ff488 with merge 4cf3c2d...
bors-servo added a commit that referenced this pull request Dec 10, 2016
@bors-servo
Auto merge of #14515 - servo:opaque, r=frewsxcv
Loading status checks…
4cf3c2d 
Update filtering in main fetch to the specification.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14515)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2016

💔 Test failed - mac-rel-wpt2
@frewsxcv
Copy link
Member

frewsxcv commented Dec 10, 2016

@bors-servo retry #14380
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2016

⌛ Testing commit d6ff488 with merge 4c4c188...
bors-servo added a commit that referenced this pull request Dec 10, 2016
@bors-servo
Auto merge of #14515 - servo:opaque, r=frewsxcv
Loading status checks…
4c4c188 
Update filtering in main fetch to the specification.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14515)
<!-- Reviewable:end -->
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 10, 2016

@bors-servo r-

This breaks loading Ahem in css tests, because we do it from a file: URL. Not sure how to deal yet.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 10, 2016

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Jan 6, 2017

What's the plan here?
@jdm
Copy link
Member

jdm commented Jan 27, 2017

@Ms2ger Are you planning to return to this?
@nox nox closed this Mar 24, 2017
@nox nox reopened this Mar 24, 2017
@jdm jdm mentioned this pull request Mar 24, 2017
Open
@jdm
Copy link
Member

jdm commented Mar 24, 2017

Tracking in #16117.
@jdm jdm closed this Mar 24, 2017
@Manishearth Manishearth deleted the opaque branch Jun 8, 2017
@jdm jdm mentioned this pull request Jun 26, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@frewsxcv frewsxcv

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@Ms2ger @highfive @frewsxcv @bors-servo @jdm @mbrubeck @nox
You can’t perform that action at this time.