Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd preference toggling touch events. #14534
Closed
Conversation
highfive
commented
Dec 9, 2016
highfive
commented
Dec 9, 2016
|
|
| @@ -7,6 +7,7 @@ | |||
| "dom.serviceworker.timeout_seconds": 60, | |||
| "dom.testable_crash.enabled": false, | |||
| "dom.testbinding.enabled": false, | |||
| "dom.w3c_touch_events.enabled": true, | |||
This comment has been minimized.
This comment has been minimized.
|
|
|
Rebased. Conflicts have been addressed. |
| @@ -2571,7 +2571,7 @@ impl DocumentMethods for Document { | |||
| let USVString(url) = self.URL(); | |||
| Ok(Root::upcast(StorageEvent::new_uninitialized(&self.window, DOMString::from(url)))) | |||
| }, | |||
| "touchevent" => | |||
| "touchevent" if PREFS.is_touch_events_enabled() => | |||
This comment has been minimized.
This comment has been minimized.
shinglyu
Dec 21, 2016
Member
Is it enough to handle it here? From compositor.rs there seem to be another path that will eventually call document.handle_touch_event() without going though here?
|
|
|
Closing due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
frewsxcv commentedDec 9, 2016
•
edited by larsbergstrom
Fixes #11477.
This change is