Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `Constellation::child_processes`. #14536

Merged
merged 2 commits into from Dec 14, 2016

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Dec 9, 2016

Fixes #11459.


This change is Reviewable

Fixes #11459.
@highfive
Copy link

highfive commented Dec 9, 2016

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/pipeline.rs, components/constellation/constellation.rs
@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 9, 2016

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 9, 2016

Do we need the ChildProcess type at all?

@KiChjang
Copy link
Member

KiChjang commented Dec 9, 2016

@jdm
Copy link
Member

jdm commented Dec 14, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

📌 Commit c11b333 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

Testing commit c11b333 with merge 01b6ad5...

bors-servo added a commit that referenced this pull request Dec 14, 2016
Remove `Constellation::child_processes`.

Fixes #11459.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14536)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

@bors-servo bors-servo merged commit c11b333 into servo:master Dec 14, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.