Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Rc from ROOTED_TRACEABLES. #14569

Merged
merged 1 commit into from Dec 14, 2016
Merged

Remove the Rc from ROOTED_TRACEABLES. #14569

merged 1 commit into from Dec 14, 2016
+2 −2

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 13, 2016 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger
Remove the Rc from ROOTED_TRACEABLES.
Loading status checks…
061350e 
It does not appear to be necessary.
@highfive
Copy link

highfive commented Dec 13, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/bindings/trace.rs
  • @KiChjang: components/script/dom/bindings/trace.rs
@highfive
Copy link

highfive commented Dec 13, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Dec 13, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

📌 Commit 061350e has been approved by emilio
@highfive highfive assigned emilio and unassigned nox Dec 13, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

⌛ Testing commit 061350e with merge 6feae0a...
bors-servo added a commit that referenced this pull request Dec 13, 2016
@bors-servo
Auto merge of #14569 - servo:ROOTED_TRACEABLES-Rc, r=emilio
Loading status checks…
6feae0a 
Remove the Rc from ROOTED_TRACEABLES.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14569)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

💔 Test failed - arm64
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Dec 13, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

⌛ Testing commit 061350e with merge 030cf90...
bors-servo added a commit that referenced this pull request Dec 14, 2016
@bors-servo
Auto merge of #14569 - servo:ROOTED_TRACEABLES-Rc, r=emilio
Loading status checks…
030cf90 
Remove the Rc from ROOTED_TRACEABLES.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14569)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 061350e into master Dec 14, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the ROOTED_TRACEABLES-Rc branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Ms2ger @highfive @emilio @bors-servo @larsbergstrom @nox
You can’t perform that action at this time.