Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some dead code related to the old network stack. #14570

Merged
merged 3 commits into from Dec 14, 2016
Merged

Remove some dead code related to the old network stack. #14570

merged 3 commits into from Dec 14, 2016

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 13, 2016 •
edited by larsbergstrom

This change is Reviewable
Ms2ger added 3 commits Dec 13, 2016
@Ms2ger
Remove unused send_error, start_sending_sniffed_opt.
1f9d7dd
@Ms2ger
Remove ProgressSender.
cd40bb5
@Ms2ger
Remove LoadConsumer, LoadResponse, ProgressMsg.
Loading status checks…
6bea1b5
@highfive
Copy link

highfive commented Dec 13, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/resource_thread.rs, components/net_traits/lib.rs, components/net_traits/lib.rs
@highfive
Copy link

highfive commented Dec 13, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Dec 13, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

📌 Commit 6bea1b5 has been approved by emilio
@highfive highfive assigned emilio and unassigned pcwalton Dec 13, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

⌛ Testing commit 6bea1b5 with merge 56c55e2...
bors-servo added a commit that referenced this pull request Dec 13, 2016
@bors-servo
Auto merge of #14570 - servo:resource-thread, r=emilio
Loading status checks…
56c55e2 
Remove some dead code related to the old network stack.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14570)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

💔 Test failed - linux-dev
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Dec 13, 2016

@bors-servo retry

  • buildbot was restarting
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

⌛ Testing commit 6bea1b5 with merge 403b4d1...
bors-servo added a commit that referenced this pull request Dec 13, 2016
@bors-servo
Auto merge of #14570 - servo:resource-thread, r=emilio
Loading status checks…
403b4d1 
Remove some dead code related to the old network stack.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14570)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

💔 Test failed - arm32
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 13, 2016

@bors-servo retry infra
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2016

⌛ Testing commit 6bea1b5 with merge d501df4...
bors-servo added a commit that referenced this pull request Dec 13, 2016
@bors-servo
Auto merge of #14570 - servo:resource-thread, r=emilio
Loading status checks…
d501df4 
Remove some dead code related to the old network stack.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14570)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 14, 2016
@bors-servo
Auto merge of #14570 - servo:resource-thread, r=emilio
Loading status checks…
a4107ab 
Remove some dead code related to the old network stack.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14570)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Dec 14, 2016

@bors-servo: retry

  • network trouble
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

⌛ Testing commit 6bea1b5 with merge fce00a9...
bors-servo added a commit that referenced this pull request Dec 14, 2016
@bors-servo
Auto merge of #14570 - servo:resource-thread, r=emilio
Loading status checks…
fce00a9 
Remove some dead code related to the old network stack.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14570)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

💔 Test failed - mac-rel-wpt2
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 14, 2016

@bors-servo retry net
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

⌛ Testing commit 6bea1b5 with merge 385d9bc...
bors-servo added a commit that referenced this pull request Dec 14, 2016
@bors-servo
Auto merge of #14570 - servo:resource-thread, r=emilio
Loading status checks…
385d9bc 
Remove some dead code related to the old network stack.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14570)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

💔 Test failed - mac-dev-unit
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Dec 14, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

⚡ Previous build results for linux-dev are reusable. Rebuilding only arm32, arm64, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 14, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 6bea1b5 into master Dec 14, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
This was referenced Dec 14, 2016
Merged
Merged
Merged
@Ms2ger Ms2ger deleted the resource-thread branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@Ms2ger @highfive @emilio @bors-servo @larsbergstrom @KiChjang @jdm @pcwalton
You can’t perform that action at this time.