Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExempt __cxa_type_match as an allowed dynamic symbol #14587
Merged
+1
−1
Conversation
highfive
commented
Dec 14, 2016
|
Heads up! This PR modifies the following files:
|
|
I have no idea if this is correct, but if it gets us to the point where we can gate on android again, it'll be an improvement. @bors-servo r+ p=1 |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 14, 2016
Exempt __cxa_type_match as an allowed dynamic symbol <!-- Please describe your changes on the following line: --> This symbol is present in the new LLVM C++ stdlib, which is loaded dynamically from a .so file during startup. Fixes #14571 r? @Ms2ger --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14587) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 14, 2016
Exempt __cxa_type_match as an allowed dynamic symbol <!-- Please describe your changes on the following line: --> This symbol is present in the new LLVM C++ stdlib, which is loaded dynamically from a .so file during startup. Fixes #14571 r? @Ms2ger --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14587) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedDec 14, 2016
•
edited
This symbol is present in the new LLVM C++ stdlib, which is loaded dynamically from a .so file during startup.
Fixes #14571
r? @Ms2ger
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is