Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the API base URL in Fetch APIs. #14632

Merged
merged 3 commits into from Dec 23, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Ensure that the API base URL is used in Fetch APIs.

  • Loading branch information
Ms2ger committed Dec 19, 2016
commit fbed4d23d67508c08fb177b88fd7458bcd046a55
@@ -0,0 +1,5 @@
[url-parsing.html]
type: testharness
[should parse the URL relative to the current settings object]
expected: FAIL

@@ -0,0 +1,5 @@
[url-parsing.html]
type: testharness
[should parse the redirect Location URL relative to the current settings object]
expected: FAIL

@@ -1,2 +1,3 @@
<!DOCTYPE html>
<title>Current page used as a test helper</title>
<base href="success/">
@@ -20,7 +20,7 @@
return loadPromise.then(() => {
const req = document.querySelector('iframe').contentWindow.createRequest("url");

assert_equals(req.url, new URL("current/url", location.href).href);
assert_equals(req.url, new URL("current/success/url", location.href).href);
});
}, "should parse the URL relative to the current settings object");

@@ -1,2 +1,3 @@
<!DOCTYPE html>
<title>Current page used as a test helper</title>
<base href="success/">
@@ -20,7 +20,7 @@
return loadPromise.then(() => {
const res = document.querySelector('iframe').contentWindow.createRedirectResponse("url");

assert_equals(res.headers.get("Location"), new URL("current/url", location.href).href);
assert_equals(res.headers.get("Location"), new URL("current/success/url", location.href).href);
});
}, "should parse the redirect Location URL relative to the current settings object");

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.