Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the API base URL in Fetch APIs. #14632

Merged
merged 3 commits into from Dec 23, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -92,8 +92,7 @@ impl Request {
let mut fallback_credentials: Option<NetTraitsRequestCredentials> = None;

// Step 4
// TODO: `entry settings object` is not implemented in Servo yet.
let base_url = global.get_url();
let base_url = global.api_base_url();

match input {
// Step 5
@@ -149,8 +149,7 @@ impl Response {
// https://fetch.spec.whatwg.org/#dom-response-redirect
pub fn Redirect(global: &GlobalScope, url: USVString, status: u16) -> Fallible<Root<Response>> {
// Step 1
// TODO: `entry settings object` is not implemented in Servo yet.
let base_url = global.get_url();
let base_url = global.api_base_url();
let parsed_url = base_url.join(&url.0);

// Step 2

This file was deleted.

This file was deleted.

@@ -1,2 +1,3 @@
<!DOCTYPE html>
<title>Current page used as a test helper</title>
<base href="success/">
@@ -6,9 +6,8 @@
<script>
'use strict';

const current = document.querySelector('#c').contentWindow;

window.createRequest = (...args) => {
const current = document.querySelector('#c').contentWindow;
return new current.Request(...args);
};

@@ -18,9 +18,9 @@

promise_test(() => {
return loadPromise.then(() => {
const req = frames[0].createRequest("url");
const req = document.querySelector('iframe').contentWindow.createRequest("url");

assert_equals(req.url, new URL("current/url", location.href).href);
assert_equals(req.url, new URL("current/success/url", location.href).href);
});
}, "should parse the URL relative to the current settings object");

@@ -1,2 +1,3 @@
<!DOCTYPE html>
<title>Current page used as a test helper</title>
<base href="success/">
@@ -7,10 +7,9 @@
<script>
'use strict';

const current = document.querySelector('#c').contentWindow;
const relevant = document.querySelector('#r').contentWindow;

window.createRedirectResponse = (...args) => {
const current = document.querySelector('#c').contentWindow;
const relevant = document.querySelector('#r').contentWindow;
return current.Response.redirect.call(relevant.Response, ...args);
};

@@ -18,9 +18,9 @@

promise_test(() => {
return loadPromise.then(() => {
const res = frames[0].createRedirectResponse("url");
const res = document.querySelector('iframe').contentWindow.createRedirectResponse("url");

assert_equals(res.headers.get("Location"), new URL("current/url", location.href).href);
assert_equals(res.headers.get("Location"), new URL("current/success/url", location.href).href);
});
}, "should parse the redirect Location URL relative to the current settings object");

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.