New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust to 1.15.0-nightly (71c06a56a 2016-12-18) #14633

Merged
merged 1 commit into from Dec 22, 2016

Conversation

Projects
None yet
@nox
Member

nox commented Dec 19, 2016

This change is Reviewable

@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Dec 19, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/treewalker.rs
  • @KiChjang: components/script/dom/treewalker.rs, components/net/image_cache_thread.rs

highfive commented Dec 19, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/treewalker.rs
  • @KiChjang: components/script/dom/treewalker.rs, components/net/image_cache_thread.rs
@highfive

This comment has been minimized.

Show comment
Hide comment
@highfive

highfive Dec 19, 2016

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!

highfive commented Dec 19, 2016

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Show comment
Hide comment
@nox
Member

nox commented Dec 19, 2016

@SimonSapin

This comment has been minimized.

Show comment
Hide comment
@SimonSapin
Member

SimonSapin commented Dec 19, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 19, 2016

Contributor

📌 Commit c5bd4e1 has been approved by SimonSapin

Contributor

bors-servo commented Dec 19, 2016

📌 Commit c5bd4e1 has been approved by SimonSapin

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 19, 2016

Contributor

⌛️ Testing commit c5bd4e1 with merge afaafc3...

Contributor

bors-servo commented Dec 19, 2016

⌛️ Testing commit c5bd4e1 with merge afaafc3...

bors-servo added a commit that referenced this pull request Dec 19, 2016

Auto merge of #14633 - servo:rustup, r=SimonSapin
Update Rust to 1.15.0-nightly (71c06a56a 2016-12-18)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14633)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 19, 2016

Contributor

💔 Test failed - linux-rel-wpt

Contributor

bors-servo commented Dec 19, 2016

💔 Test failed - linux-rel-wpt

@SimonSapin

This comment has been minimized.

Show comment
Hide comment
@SimonSapin
Member

SimonSapin commented Dec 19, 2016

@KiChjang

This comment has been minimized.

Show comment
Hide comment
@KiChjang
Member

KiChjang commented Dec 19, 2016

@bors-servo r- clean

@KiChjang

This comment has been minimized.

Show comment
Hide comment
@KiChjang
Member

KiChjang commented Dec 19, 2016

@KiChjang

This comment has been minimized.

Show comment
Hide comment
@KiChjang

KiChjang Dec 19, 2016

Member

@bors-servo r- try- clean

Member

KiChjang commented Dec 19, 2016

@bors-servo r- try- clean

@KiChjang

This comment has been minimized.

Show comment
Hide comment
@KiChjang

KiChjang Dec 19, 2016

Member

@bors-servo try retry

Member

KiChjang commented Dec 19, 2016

@bors-servo try retry

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 19, 2016

Contributor

⌛️ Trying commit c5bd4e1 with merge 6517409...

Contributor

bors-servo commented Dec 19, 2016

⌛️ Trying commit c5bd4e1 with merge 6517409...

bors-servo added a commit that referenced this pull request Dec 19, 2016

Auto merge of #14633 - servo:rustup, r=<try>
Update Rust to 1.15.0-nightly (71c06a56a 2016-12-18)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14633)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 19, 2016

Contributor

💔 Test failed - linux-rel-wpt

Contributor

bors-servo commented Dec 19, 2016

💔 Test failed - linux-rel-wpt

@SimonSapin

This comment has been minimized.

Show comment
Hide comment
@SimonSapin

SimonSapin Dec 19, 2016

Member

So, that’s two runs with identical failures:

{"status": "FAIL", "stack": null, "subtest": null, "action": "test_result", "test": "/_mozilla/css/border_radius_asymmetric_sizes_a.html", "line": 13216, "message": "/_mozilla/css/border_radius_asymmetric_sizes_a.html 327908e8e5639151bbfceb0c4a78876203042ed1\n/_mozilla/css/border_radius_asymmetric_sizes_ref.html 5a9a64f75ad410d2c74e45ceda1c9efa61203c14\nTesting 327908e8e5639151bbfceb0c4a78876203042ed1 == 5a9a64f75ad410d2c74e45ceda1c9efa61203c14", "expected": "PASS"}
{"status": "PASS", "stack": null, "subtest": null, "action": "test_result", "test": "/_mozilla/css/text_decoration_underline_subpx_a.html", "line": 16535, "message": null, "expected": "FAIL"}
{"status": "FAIL", "stack": null, "subtest": null, "action": "test_result", "test": "/_mozilla/css/word-break-keep-all-005.htm", "line": 30050, "message": "/_mozilla/css/word-break-keep-all-005.htm 553453fad4db496e2aab49f65a8af2ec63909388\n/_mozilla/css/word-break-keep-all-ref-005.htm ec3b8afcf107bfa4cd93ad6b32c9238dfec0356d\nTesting 553453fad4db496e2aab49f65a8af2ec63909388 == ec3b8afcf107bfa4cd93ad6b32c9238dfec0356d", "expected": "PASS"}
Member

SimonSapin commented Dec 19, 2016

So, that’s two runs with identical failures:

{"status": "FAIL", "stack": null, "subtest": null, "action": "test_result", "test": "/_mozilla/css/border_radius_asymmetric_sizes_a.html", "line": 13216, "message": "/_mozilla/css/border_radius_asymmetric_sizes_a.html 327908e8e5639151bbfceb0c4a78876203042ed1\n/_mozilla/css/border_radius_asymmetric_sizes_ref.html 5a9a64f75ad410d2c74e45ceda1c9efa61203c14\nTesting 327908e8e5639151bbfceb0c4a78876203042ed1 == 5a9a64f75ad410d2c74e45ceda1c9efa61203c14", "expected": "PASS"}
{"status": "PASS", "stack": null, "subtest": null, "action": "test_result", "test": "/_mozilla/css/text_decoration_underline_subpx_a.html", "line": 16535, "message": null, "expected": "FAIL"}
{"status": "FAIL", "stack": null, "subtest": null, "action": "test_result", "test": "/_mozilla/css/word-break-keep-all-005.htm", "line": 30050, "message": "/_mozilla/css/word-break-keep-all-005.htm 553453fad4db496e2aab49f65a8af2ec63909388\n/_mozilla/css/word-break-keep-all-ref-005.htm ec3b8afcf107bfa4cd93ad6b32c9238dfec0356d\nTesting 553453fad4db496e2aab49f65a8af2ec63909388 == ec3b8afcf107bfa4cd93ad6b32c9238dfec0356d", "expected": "PASS"}
@SimonSapin

This comment has been minimized.

Show comment
Hide comment
@SimonSapin

SimonSapin Dec 20, 2016

Member

I can reproduce text_decoration_underline_subpx_a.html PASS expected FAIL, both on this branch and on master. The failure is marked expected on Linux only. I don’t know what happened exactly, but maybe we can just remove it?

I can reliably reproduce the border_radius_asymmetric_sizes_a.html failure (on this branch but not on master), but not the word-break-keep-all-005.htm one…

Let’s try it once more to see what happens.

@bors-servo try

Member

SimonSapin commented Dec 20, 2016

I can reproduce text_decoration_underline_subpx_a.html PASS expected FAIL, both on this branch and on master. The failure is marked expected on Linux only. I don’t know what happened exactly, but maybe we can just remove it?

I can reliably reproduce the border_radius_asymmetric_sizes_a.html failure (on this branch but not on master), but not the word-break-keep-all-005.htm one…

Let’s try it once more to see what happens.

@bors-servo try

@SimonSapin

This comment has been minimized.

Show comment
Hide comment
@SimonSapin
Member

SimonSapin commented Dec 20, 2016

@bors-servo try retry

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 20, 2016

Contributor

⌛️ Trying commit c5bd4e1 with merge 31948ec...

Contributor

bors-servo commented Dec 20, 2016

⌛️ Trying commit c5bd4e1 with merge 31948ec...

bors-servo added a commit that referenced this pull request Dec 20, 2016

Auto merge of #14633 - servo:rustup, r=<try>
Update Rust to 1.15.0-nightly (71c06a56a 2016-12-18)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14633)
<!-- Reviewable:end -->
@Ms2ger

This comment has been minimized.

Show comment
Hide comment
@Ms2ger

Ms2ger Dec 20, 2016

Contributor
Contributor

Ms2ger commented Dec 20, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 20, 2016

Contributor

⌛️ Trying commit 28cc9b0 with merge 6d7c020...

Contributor

bors-servo commented Dec 20, 2016

⌛️ Trying commit 28cc9b0 with merge 6d7c020...

bors-servo added a commit that referenced this pull request Dec 20, 2016

Auto merge of #14633 - servo:rustup, r=<try>
Update Rust to 1.15.0-nightly (71c06a56a 2016-12-18)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14633)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 20, 2016

Contributor

💔 Test failed - linux-rel-wpt

Contributor

bors-servo commented Dec 20, 2016

💔 Test failed - linux-rel-wpt

@SimonSapin

This comment has been minimized.

Show comment
Hide comment
@SimonSapin

SimonSapin Dec 21, 2016

Member

Screenshots bellow are of border_radius_asymmetric_sizes_ref.html, scrolled to the bottom because things are move visible there. Each squareish thing is a single element with borders of different colors on each four sides.

The rendering of these borders in Servo is messed up, but that could be an unrelated WebRender bug. What’s more worrying to me right now is that the text became bold just by upgrading the compiler.

Could it be that #[repr(C)] is missing on some type used with Freetype or Fontconfig? (Since rust-lang/rust#37429 "struct field reordering" is among the compiler changes.)


On Servo master, or this PR downgraded to rustc 8f02c429a 2016-12-15 (they give identical rendering):

nightly-2016-11-28

In this PR (rustc 8f02c429a 2016-12-15):

nightly-2016-12-18

In Firefox:

firefox

Member

SimonSapin commented Dec 21, 2016

Screenshots bellow are of border_radius_asymmetric_sizes_ref.html, scrolled to the bottom because things are move visible there. Each squareish thing is a single element with borders of different colors on each four sides.

The rendering of these borders in Servo is messed up, but that could be an unrelated WebRender bug. What’s more worrying to me right now is that the text became bold just by upgrading the compiler.

Could it be that #[repr(C)] is missing on some type used with Freetype or Fontconfig? (Since rust-lang/rust#37429 "struct field reordering" is among the compiler changes.)


On Servo master, or this PR downgraded to rustc 8f02c429a 2016-12-15 (they give identical rendering):

nightly-2016-11-28

In this PR (rustc 8f02c429a 2016-12-15):

nightly-2016-12-18

In Firefox:

firefox

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb

eddyb Dec 21, 2016

Contributor

FWIW servo/rust-freetype@c796066 fixes the bold problem for me (except for me it's the lack of bold on <h2> as opposed to other things being bold).

Contributor

eddyb commented Dec 21, 2016

FWIW servo/rust-freetype@c796066 fixes the bold problem for me (except for me it's the lack of bold on <h2> as opposed to other things being bold).

@nox

This comment has been minimized.

Show comment
Hide comment
@nox
Member

nox commented Dec 21, 2016

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 21, 2016

Contributor

⌛️ Trying commit e73c1cb with merge 57c1dd7...

Contributor

bors-servo commented Dec 21, 2016

⌛️ Trying commit e73c1cb with merge 57c1dd7...

bors-servo added a commit that referenced this pull request Dec 21, 2016

Auto merge of #14633 - servo:rustup, r=<try>
Update Rust to 1.15.0-nightly (71c06a56a 2016-12-18)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14633)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
Contributor

bors-servo commented Dec 21, 2016

@nox

This comment has been minimized.

Show comment
Hide comment
@nox

nox Dec 21, 2016

Member

@bors-servo r=SimonSapin,nox

Member

nox commented Dec 21, 2016

@bors-servo r=SimonSapin,nox

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 21, 2016

Contributor

📌 Commit 2cc1b84 has been approved by SimonSapin,nox

Contributor

bors-servo commented Dec 21, 2016

📌 Commit 2cc1b84 has been approved by SimonSapin,nox

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Dec 22, 2016

Contributor

⌛️ Testing commit 2cc1b84 with merge df667f1...

Contributor

bors-servo commented Dec 22, 2016

⌛️ Testing commit 2cc1b84 with merge df667f1...

bors-servo added a commit that referenced this pull request Dec 22, 2016

Auto merge of #14633 - servo:rustup, r=SimonSapin,nox
Update Rust to 1.15.0-nightly (71c06a56a 2016-12-18)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14633)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Show comment
Hide comment
Contributor

bors-servo commented Dec 22, 2016

@bors-servo bors-servo merged commit 2cc1b84 into master Dec 22, 2016

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details

@nox nox deleted the rustup branch Dec 22, 2016

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Dec 22, 2016

Member

@jdm @Ms2ger Doesn't rust-lang/rust#37429 mean that our DOM inheritance thing might need some fixes? We used to rely on the fact that the first field is always the parent. I did update some code to use &foo.firstfieldname instead of transmuting at some point but I don't think that's all of it.

Member

Manishearth commented Dec 22, 2016

@jdm @Ms2ger Doesn't rust-lang/rust#37429 mean that our DOM inheritance thing might need some fixes? We used to rely on the fact that the first field is always the parent. I did update some code to use &foo.firstfieldname instead of transmuting at some point but I don't think that's all of it.

@eddyb

This comment has been minimized.

Show comment
Hide comment
@eddyb

eddyb Dec 22, 2016

Contributor

@Manishearth You used #[repr(C)] with that, right? Riiiight? Anything else is irresponsible.

Contributor

eddyb commented Dec 22, 2016

@Manishearth You used #[repr(C)] with that, right? Riiiight? Anything else is irresponsible.

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth Dec 22, 2016

Member

We didn't :) Like I said, I tried to get rid of the transmutes at some point, but it's changed a lot since then and I don't even remember.

Member

Manishearth commented Dec 22, 2016

We didn't :) Like I said, I tried to get rid of the transmutes at some point, but it's changed a lot since then and I don't even remember.

@nox

This comment has been minimized.

Show comment
Hide comment
@nox

nox Dec 22, 2016

Member

@eddyb I plan to do that today or tomorrow, but wasn't going to block rustup on it since the tests pass.

Member

nox commented Dec 22, 2016

@eddyb I plan to do that today or tomorrow, but wasn't going to block rustup on it since the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment