Implemented XMLHttpRequest.send(Document) #14648

cynicaldevil · 2016-12-20T19:15:12Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors
These changes fix #9490 .

XMLHttpRequest/send-entity-body-document.htm is not working atm, I get this output:

$ ./mach test-wpt tests/wpt/web-platform-tests/XMLHttpRequest/send-entity-body-document.htm
Running 1 tests in web-platform-tests

Ran 1 tests finished in 0.0 seconds.
  • 1 ran as expected. 1 tests skipped.

This change is

KiChjang · 2016-12-20T19:17:05Z

components/script/dom/xmlhttprequest.rs

+            Some(DocumentOrBodyInit::Blob(ref b)) => { Some(b.extract()) },
+            Some(DocumentOrBodyInit::FormData(ref formdata)) => { Some(formdata.extract()) },
+            Some(DocumentOrBodyInit::String(ref str)) => { Some(str.extract()) },
+            Some(DocumentOrBodyInit::URLSearchParams(ref urlsp)) => { Some(urlsp.extract()) },


nit: Braces are not required when you only have 1 expression inside of it.

KiChjang · 2016-12-20T19:18:35Z

components/script/dom/xmlhttprequest.rs

+    }
+}
+
+pub fn serialize_document(doc: &Document) -> Fallible<DOMString> {


nit: Doesn't really need to be pub.

KiChjang · 2016-12-20T19:22:31Z

Great work! This is very easy to review for the eyes. For the ignored test case, check to make sure that the tests under that directory is enabled (look for tests/wpt/include.ini and tests/wpt/metadata/XMLHttpRequest/send-entity-body-document.htm.ini and inspect their contents to see if they've marked the test as disabled).

cynicaldevil · 2016-12-20T19:24:02Z

It is. Are there any other tests related to this? Like send-entity-body-document-bogus.htm?

KiChjang · 2016-12-20T19:25:55Z

Ah ok, you need to remove tests/wpt/metadata/XMLHttpRequest/send-entity-body-document.htm.ini.

cynicaldevil · 2016-12-20T19:40:12Z

I tried it, I am getting something like this (image stolen from prev. PR, its identical) :

KiChjang · 2016-12-20T20:12:14Z

components/script/dom/xmlhttprequest.rs

-        let extracted = data.as_ref().map(|d| d.extract());
+        let extracted_or_serialized = match data {
+            Some(DocumentOrBodyInit::Document(ref doc)) => {
+                let data = Vec::from(serialize_document(&doc).unwrap().as_ref());


You should really check whether serialize_document returns an Err or not instead of unwrapping. If it does, return Err(Error::InvalidState).

KiChjang · 2016-12-20T20:57:21Z

@bors-servo try

bors-servo · 2016-12-20T20:57:26Z

⌛ Trying commit f62ae44 with merge 54dd4ab...


        Auto merge of #14648 - cynicaldevil:xmlhttpreq-send, r=<try>

@KiChjang

Implemented XMLHttpRequest.send(Document)  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9490 .  r? @KiChjang `XMLHttpRequest/send-entity-body-document.htm` is not working atm, I get this output: ``` $ ./mach test-wpt tests/wpt/web-platform-tests/XMLHttpRequest/send-entity-body-document.htm Running 1 tests in web-platform-tests Ran 1 tests finished in 0.0 seconds. • 1 ran as expected. 1 tests skipped. ```   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14648)

bors-servo · 2016-12-20T21:34:33Z

💔 Test failed - mac-rel-wpt1

KiChjang · 2016-12-20T21:41:33Z

Not a lot of tests are passing; the implementation looks like it needs improvement.

Tests with unexpected results:
  ▶ Unexpected subtest result in /html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen.html:
  └ PASS [expected FAIL] iframe-noload-noallowfullscreen

  ▶ Unexpected subtest result in /html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen.html:
  └ PASS [expected FAIL] iframe-noload-allowfullscreen

  ▶ Unexpected subtest result in /XMLHttpRequest/setrequestheader-content-type.htm:
  └ PASS [expected FAIL] XML Document request has correct default Content-Type of "application/xml;charset=UTF-8"

  ▶ Unexpected subtest result in /XMLHttpRequest/setrequestheader-content-type.htm:
  └ PASS [expected FAIL] HTML Document request has correct default Content-Type of "text/html;charset=UTF-8"

  ▶ Unexpected subtest result in /XMLHttpRequest/setrequestheader-content-type.htm:
  │ FAIL [expected PASS] HTML Document request keeps setRequestHeader() Content-Type, with charset adjusted to UTF-8
  │   → assert_equals: expected "content-type: text/html+junk;charset=utf-8" but got "content-type: text/html+junk;charset=ascii"
  │ 
  │ request/<@http://web-platform.test:8000/XMLHttpRequest/setrequestheader-content-type.htm:26:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  │ test@http://web-platform.test:8000/resources/testharness.js:501:9
  │ request@http://web-platform.test:8000/XMLHttpRequest/setrequestheader-content-type.htm:3:9
  └ @http://web-platform.test:8000/XMLHttpRequest/setrequestheader-content-type.htm:96:7

  ▶ Unexpected subtest result in /XMLHttpRequest/setrequestheader-content-type.htm:
  │ FAIL [expected PASS] XML Document request keeps setRequestHeader() Content-Type, with charset adjusted to UTF-8
  │   → assert_equals: expected "content-type: application/xhtml+xml;charset=utf-8" but got "content-type: application/xhtml+xml;charset=ascii"
  │ 
  │ request/<@http://web-platform.test:8000/XMLHttpRequest/setrequestheader-content-type.htm:26:13
  │ Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:1406:20
  │ test@http://web-platform.test:8000/resources/testharness.js:501:9
  │ request@http://web-platform.test:8000/XMLHttpRequest/setrequestheader-content-type.htm:3:9
  └ @http://web-platform.test:8000/XMLHttpRequest/setrequestheader-content-type.htm:78:7

cynicaldevil · 2016-12-20T22:33:34Z

hmm...two failing tests, plus send-entity-body-document.htm and send-entity-body-document-bogus.htm...I'll look into these tomorrow.

Ms2ger · 2016-12-21T11:04:24Z

iframe-allowfullscreen.html is #14607; you can ignore that. As for the failure in setrequestheader-content-type.htm, you may be missing the requirement

Otherwise, if the header named Content-Type in author request headers has a value that is a valid MIME type, which has a charset parameter whose value is not a case-insensitive match for encoding, and encoding is not null, then set all the charset parameters whose value is not a case-insensitive match for encoding of that Content-Type header's value to encoding.

cynicaldevil · 2016-12-23T19:20:06Z

@Ms2ger fixed it, also updated the manifests for passing tests.

For send-entity-body-document-bogus.htm.ini the error's defintely occuring in the function call serialize in xmlhttprequest.rs (line 1394), because the test passes when I explicitly return Err(Error::InvalidState) from serialize_document.

KiChjang · 2016-12-23T19:35:40Z

@bors-servo try

bors-servo · 2016-12-23T19:35:45Z

⌛ Trying commit 4133207 with merge 7fa803b...


        Auto merge of #14648 - cynicaldevil:xmlhttpreq-send, r=<try>

@KiChjang

Implemented XMLHttpRequest.send(Document)  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9490 .  r? @KiChjang `XMLHttpRequest/send-entity-body-document.htm` is not working atm, I get this output: ``` $ ./mach test-wpt tests/wpt/web-platform-tests/XMLHttpRequest/send-entity-body-document.htm Running 1 tests in web-platform-tests Ran 1 tests finished in 0.0 seconds. • 1 ran as expected. 1 tests skipped. ```   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14648)

bors-servo · 2016-12-23T20:11:15Z

💔 Test failed - arm32

cynicaldevil · 2016-12-24T09:54:36Z

@bors-servo retry servo/saltfs#565

bors-servo · 2016-12-24T09:54:41Z

⌛ Trying commit 4133207 with merge 37177b1...


        Auto merge of #14648 - cynicaldevil:xmlhttpreq-send, r=<try>

@KiChjang

Implemented XMLHttpRequest.send(Document)  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9490 .  r? @KiChjang `XMLHttpRequest/send-entity-body-document.htm` is not working atm, I get this output: ``` $ ./mach test-wpt tests/wpt/web-platform-tests/XMLHttpRequest/send-entity-body-document.htm Running 1 tests in web-platform-tests Ran 1 tests finished in 0.0 seconds. • 1 ran as expected. 1 tests skipped. ```   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14648)

bors-servo · 2016-12-24T11:00:47Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

bors-servo · 2017-01-07T23:14:32Z

⌛ Testing commit 401836e with merge 063fc17...


        Auto merge of #14648 - cynicaldevil:xmlhttpreq-send, r=cynicaldevil

@KiChjang

Implemented XMLHttpRequest.send(Document)  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9490 .  r? @KiChjang `XMLHttpRequest/send-entity-body-document.htm` is not working atm, I get this output: ``` $ ./mach test-wpt tests/wpt/web-platform-tests/XMLHttpRequest/send-entity-body-document.htm Running 1 tests in web-platform-tests Ran 1 tests finished in 0.0 seconds. • 1 ran as expected. 1 tests skipped. ```   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14648)

bors-servo · 2017-01-07T23:28:14Z

💔 Test failed - linux-dev

KiChjang · 2017-01-08T02:20:03Z

@bors-servo r- r+ retry

bors-servo · 2017-01-08T02:20:04Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: #14905

bors-servo · 2017-01-08T02:20:04Z

📌 Commit 401836e has been approved by KiChjang

bors-servo · 2017-01-08T03:08:54Z

⌛ Testing commit 401836e with merge 95dec99...


        Auto merge of #14648 - cynicaldevil:xmlhttpreq-send, r=KiChjang

@KiChjang

Implemented XMLHttpRequest.send(Document)  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9490 .  r? @KiChjang `XMLHttpRequest/send-entity-body-document.htm` is not working atm, I get this output: ``` $ ./mach test-wpt tests/wpt/web-platform-tests/XMLHttpRequest/send-entity-body-document.htm Running 1 tests in web-platform-tests Ran 1 tests finished in 0.0 seconds. • 1 ran as expected. 1 tests skipped. ```   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14648)

bors-servo · 2017-01-08T03:22:33Z

💔 Test failed - linux-dev

KiChjang · 2017-01-08T08:21:13Z

@bors-servo retry

bors-servo · 2017-01-08T08:21:15Z

⌛ Testing commit 401836e with merge 87cce81...


        Auto merge of #14648 - cynicaldevil:xmlhttpreq-send, r=KiChjang

@KiChjang

Implemented XMLHttpRequest.send(Document)  ---  - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #9490 .  r? @KiChjang `XMLHttpRequest/send-entity-body-document.htm` is not working atm, I get this output: ``` $ ./mach test-wpt tests/wpt/web-platform-tests/XMLHttpRequest/send-entity-body-document.htm Running 1 tests in web-platform-tests Ran 1 tests finished in 0.0 seconds. • 1 ran as expected. 1 tests skipped. ```   --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14648)

bors-servo · 2017-01-08T08:34:35Z

💔 Test failed - linux-dev

KiChjang · 2017-01-08T09:19:52Z

@bors-servo retry

bors-servo · 2017-01-08T09:19:54Z

⚡ Previous build results for android, arm64, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only arm32, linux-dev...

bors-servo · 2017-01-08T09:37:35Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev

KiChjang reviewed Dec 20, 2016

View changes

components/script/dom/xmlhttprequest.rs Outdated

}

}

pub fn serialize_document(doc: &Document) -> Fallible<DOMString> {

This comment has been minimized.

Sign in to view

KiChjang Dec 20, 2016 •

edited

Member

nit: Doesn't really need to be pub.

KiChjang self-assigned this Dec 20, 2016

KiChjang added the S-needs-code-changes label Dec 20, 2016

KiChjang reviewed Dec 20, 2016

View changes

highfive added the S-tests-failed label Dec 20, 2016

highfive added S-awaiting-review and removed S-tests-failed S-needs-code-changes labels Dec 23, 2016

highfive added the S-tests-failed label Dec 23, 2016

highfive added S-awaiting-merge and removed S-awaiting-review labels Jan 7, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 7, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 8, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 8, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels Jan 8, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels Jan 8, 2017

bors-servo merged commit 401836e into servo:master Jan 8, 2017
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

homu Test successful
Details

cynicaldevil deleted the cynicaldevil:xmlhttpreq-send branch Jul 29, 2017

servo / servo

Implemented XMLHttpRequest.send(Document) #14648

Implemented XMLHttpRequest.send(Document) #14648

cynicaldevil commented Dec 20, 2016 •

edited by larsbergstrom

This comment has been minimized.

This comment has been minimized.

KiChjang commented Dec 20, 2016

cynicaldevil commented Dec 20, 2016 •

edited

KiChjang commented Dec 20, 2016

cynicaldevil commented Dec 20, 2016

This comment has been minimized.

This comment has been minimized.

KiChjang commented Dec 20, 2016

bors-servo commented Dec 20, 2016

bors-servo commented Dec 20, 2016

KiChjang commented Dec 20, 2016

cynicaldevil commented Dec 20, 2016

Ms2ger commented Dec 21, 2016

cynicaldevil commented Dec 23, 2016 •

edited

KiChjang commented Dec 23, 2016

bors-servo commented Dec 23, 2016

bors-servo commented Dec 23, 2016

cynicaldevil commented Dec 24, 2016

bors-servo commented Dec 24, 2016

bors-servo commented Dec 24, 2016

bors-servo commented Jan 7, 2017

bors-servo commented Jan 7, 2017

KiChjang commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

KiChjang commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

KiChjang commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

servo / servo

Join GitHub today

Implemented XMLHttpRequest.send(Document) #14648

Implemented XMLHttpRequest.send(Document) #14648

Conversation

cynicaldevil commented Dec 20, 2016 • edited by larsbergstrom

This comment has been minimized.

KiChjang Dec 20, 2016

This comment has been minimized.

KiChjang Dec 20, 2016 • edited

KiChjang commented Dec 20, 2016

cynicaldevil commented Dec 20, 2016 • edited

KiChjang commented Dec 20, 2016

cynicaldevil commented Dec 20, 2016

This comment has been minimized.

KiChjang Dec 20, 2016

This comment has been minimized.

cynicaldevil Dec 20, 2016

KiChjang commented Dec 20, 2016

bors-servo commented Dec 20, 2016

bors-servo commented Dec 20, 2016

KiChjang commented Dec 20, 2016

cynicaldevil commented Dec 20, 2016

Ms2ger commented Dec 21, 2016

cynicaldevil commented Dec 23, 2016 • edited

KiChjang commented Dec 23, 2016

bors-servo commented Dec 23, 2016

bors-servo commented Dec 23, 2016

cynicaldevil commented Dec 24, 2016

bors-servo commented Dec 24, 2016

bors-servo commented Dec 24, 2016

bors-servo commented Jan 7, 2017

bors-servo commented Jan 7, 2017

KiChjang commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

KiChjang commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

KiChjang commented Jan 8, 2017

bors-servo commented Jan 8, 2017

bors-servo commented Jan 8, 2017

cynicaldevil commented Dec 20, 2016 •

edited by larsbergstrom

KiChjang Dec 20, 2016 •

edited

cynicaldevil commented Dec 20, 2016 •

edited

cynicaldevil commented Dec 23, 2016 •

edited