Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to quickersort 2.2 #14652

Merged
merged 1 commit into from Dec 21, 2016
Merged

Update to quickersort 2.2 #14652

merged 1 commit into from Dec 21, 2016

Conversation

@notriddle
Copy link
Contributor

notriddle commented Dec 20, 2016 •
edited by larsbergstrom

This change is Reviewable
@notriddle
Update to quickersort 2.2
Loading status checks…
e754387
@KiChjang
Copy link
Member

KiChjang commented Dec 20, 2016 •
edited

Woah, that's a minor version change, did any interfaces break?
@notriddle
Copy link
Contributor Author

notriddle commented Dec 20, 2016

Not that I know of. I didn't modify any of the tests, and they all pass.
@metajack
Copy link
Contributor

metajack commented Dec 20, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 20, 2016

📌 Commit e754387 has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2016

⌛ Testing commit e754387 with merge 53dff51...
bors-servo added a commit that referenced this pull request Dec 21, 2016
@bors-servo
Auto merge of #14652 - servo:always_be_updating, r=metajack
Loading status checks…
53dff51 
Update to quickersort 2.2

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14652)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2016

💔 Test failed - linux-rel-css
@KiChjang
Copy link
Member

KiChjang commented Dec 21, 2016

wat

Tests with unexpected results:
  ▶ PASS [expected TIMEOUT] /css-flexbox-1_dev/html/css-flexbox-height-animation-stretch.htm

@notriddle Is this actually possible or is this an actual intermittent?
@KiChjang
Copy link
Member

KiChjang commented Dec 21, 2016

@bors-servo r- try retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2016

⌛ Trying commit e754387 with merge b095d06...
bors-servo added a commit that referenced this pull request Dec 21, 2016
@bors-servo
Auto merge of #14652 - servo:always_be_updating, r=<try>
Loading status checks…
b095d06 
Update to quickersort 2.2

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14652)
<!-- Reviewable:end -->
@notriddle
Copy link
Contributor Author

notriddle commented Dec 21, 2016

According to #12328, that should be impossible.
@notriddle
Copy link
Contributor Author

notriddle commented Dec 21, 2016

I'm willing to believe it's an intermittent, though. Everything else is.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@emilio
Copy link
Member

emilio commented Dec 21, 2016

@bors-servo try- r=metajack
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2016

📌 Commit e754387 has been approved by metajack
@Ms2ger
Copy link
Contributor

Ms2ger commented Dec 21, 2016

@bors-servo r- try- r=metajack retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2016

💡 This pull request was already approved, no need to approve it again.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2016

📌 Commit e754387 has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2016

⌛ Testing commit e754387 with merge 50c9311...
bors-servo added a commit that referenced this pull request Dec 21, 2016
@bors-servo
Auto merge of #14652 - servo:always_be_updating, r=metajack
Loading status checks…
50c9311 
Update to quickersort 2.2

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14652)
<!-- Reviewable:end -->
@KiChjang
Copy link
Member

KiChjang commented Dec 21, 2016

Filed #14656 for the new passing intermittent.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 21, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit e754387 into master Dec 21, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
This was referenced Dec 21, 2016
Merged
Merged
@notriddle notriddle deleted the always_be_updating branch Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@metajack metajack

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@notriddle @KiChjang @metajack @bors-servo @emilio @Ms2ger @highfive
You can’t perform that action at this time.