Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Document::head() #1466

Merged
merged 1 commit into from Jan 7, 2014
Merged

Implement Document::head() #1466

merged 1 commit into from Jan 7, 2014

Conversation

@brunoabinader
Copy link
Contributor

brunoabinader commented Jan 7, 2014

Implementation details according to the specification below:
http://www.whatwg.org/specs/web-apps/current-work/#dom-document-head

This patch is for:
#1465

Closes #1465.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 7, 2014

Critic review: https://critic.hoppipolla.co.uk/r/530

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@kmcallister
Copy link
Contributor

kmcallister commented Jan 7, 2014

If you make that change and squash these two commits then I'm ready to merge this.
@brunoabinader
Implement Document::head()
Loading status checks…
17b35d5 
Implementation details according to the specification below:
http://www.whatwg.org/specs/web-apps/current-work/#dom-document-head

This patch is for:
#1465
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 17b35d5 Jan 7, 2014

saw approval from kmcallister
at https://github.com/brunoabinader/servo/commit/17b35d52fff79f56b3aa734a1bb3924780e8fb04

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 7, 2014

merging brunoabinader/servo/document-head = 17b35d5 into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 7, 2014

brunoabinader/servo/document-head = 17b35d5 merged ok, testing candidate = a910e4e

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 7, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/775
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/730

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 7, 2014

fast-forwarding master to auto = a910e4e
bors-servo pushed a commit that referenced this pull request Jan 7, 2014
bors-servo
auto merge of #1466 : brunoabinader/servo/document-head, r=kmcallister
a910e4e 
Implementation details according to the specification below:
http://www.whatwg.org/specs/web-apps/current-work/#dom-document-head

This patch is for:
#1465

Closes #1465.
@bors-servo bors-servo merged commit 17b35d5 into servo:master Jan 7, 2014
1 check passed
1 check passed
default all tests passed
@brunoabinader brunoabinader deleted the brunoabinader:document-head branch Jan 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement Document::head()
4 participants
@brunoabinader @hoppipolla-critic-bot @kmcallister @bors-servo
You can’t perform that action at this time.