New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added current_line variable to track current line #14661
Closed
+59
−10
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
24d5f8b
Added current_line variable to Sink and set_current_line function. Ad…
karenher 3a0f9fa
Removed line_number parameter from create function and added argument…
karenher d80d24b
Moved comment and added function to match ElementCreator enum variant.
karenher a0fea2e
Separated function into one that returns boolean and one that returns…
karenher 46e1912
Created HTML test file for tracking line number. Test currently fails.
karenher 5a76da8
Updated function call evaluate_script_on_global_with_result. Test htm…
karenher File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Loading status checks…
Added current_line variable to Sink and set_current_line function. Ad…
…ded line_number parameter to Element::create function and set corresponding calls to this function to take in 1 for line_number argument
- Loading branch information
commit 24d5f8b3f4a9e03278ad03f76dfb94e15b48d222
| @@ -129,7 +129,7 @@ impl<'a> TreeSink for Sink { | ||
| local: name.local, | ||
| }; | ||
| let elem = Element::create(name, prefix, &*self.document, | ||
| ElementCreator::ParserCreated); | ||
| ElementCreator::ParserCreated, 1); | ||
jdm
Member
|
||
|
|
||
| for attr in attrs { | ||
| let name = QualName { | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Given how many places end up creating elements and passing fake line number values, I propose we modify the ElementCreator enum such that the
ParserCreatedvariant takes a line number argument instead. This will mean that we don't need an extra argument here.