New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added current_line variable to track current line #14661
Closed
+59
−10
Closed
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
24d5f8b
Added current_line variable to Sink and set_current_line function. Ad…
karenher 3a0f9fa
Removed line_number parameter from create function and added argument…
karenher d80d24b
Moved comment and added function to match ElementCreator enum variant.
karenher a0fea2e
Separated function into one that returns boolean and one that returns…
karenher 46e1912
Created HTML test file for tracking line number. Test currently fails.
karenher 5a76da8
Updated function call evaluate_script_on_global_with_result. Test htm…
karenher File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Loading status checks…
Moved comment and added function to match ElementCreator enum variant.
- Loading branch information
commit d80d24be413192e2374afc5d5881bf75210e45ed
| @@ -64,6 +64,9 @@ pub struct HTMLScriptElement { | ||
|
|
||
| /// The source this script was loaded from | ||
| load: DOMRefCell<Option<Result<ScriptOrigin, NetworkError>>>, | ||
|
|
||
| /// Track line line_number | ||
| line_number: u64, | ||
| } | ||
|
|
||
| impl HTMLScriptElement { | ||
| @@ -78,6 +81,7 @@ impl HTMLScriptElement { | ||
| ready_to_be_parser_executed: Cell::new(false), | ||
jdm
Member
|
||
| parser_document: JS::from_ref(document), | ||
| load: DOMRefCell::new(None), | ||
| line_number: creator.is_parser_created(), | ||
| } | ||
| } | ||
|
|
||
| @@ -495,7 +499,7 @@ impl HTMLScriptElement { | ||
| let window = window_from_node(self); | ||
| rooted!(in(window.get_cx()) let mut rval = UndefinedValue()); | ||
| window.upcast::<GlobalScope>().evaluate_script_on_global_with_result( | ||
| &script.text, script.url.as_str(), rval.handle_mut()); | ||
| &script.text, script.url.as_str(), rval.handle_mut(), 1); | ||
|
|
||
| // Step 6. | ||
| document.set_current_script(old_script.r()); | ||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The name of this method does not match what this method is actually doing. We should be returning a boolean here; the comment I made about extracting the line number belongs in a separate method.