New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added current_line variable to track current line #14661
Closed
+59
−10
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
24d5f8b
Added current_line variable to Sink and set_current_line function. Ad…
karenher 3a0f9fa
Removed line_number parameter from create function and added argument…
karenher d80d24b
Moved comment and added function to match ElementCreator enum variant.
karenher a0fea2e
Separated function into one that returns boolean and one that returns…
karenher 46e1912
Created HTML test file for tracking line number. Test currently fails.
karenher 5a76da8
Updated function call evaluate_script_on_global_with_result. Test htm…
karenher File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
| "url": "/_mozilla/mozilla/trace_null.html" | ||
| } | ||
| ], | ||
| "mozilla/track_line.html": [ | ||
| { | ||
| "path": "mozilla/track_line.html", | ||
| "url": "/_mozilla/mozilla/track_line.html" | ||
| } | ||
| ], | ||
| "mozilla/union.html": [ | ||
| { | ||
| "path": "mozilla/union.html", |
| @@ -0,0 +1,17 @@ | ||
| <!doctype html> | ||
| <meta charset="utf-8"> | ||
| <title></title> | ||
| <script src="/resources/testharness.js"></script> | ||
| <script src="/resources/testharnessreport.js"></script> | ||
| <script> | ||
| setup({allow_uncaught_exception:true}); | ||
| var t = async_test("error event has proper line number"); | ||
| window.addEventListener('error', t.step_func(function(e) { | ||
| assert_true(e instanceof ErrorEvent); | ||
| assert_equals(e.lineno, 16); | ||
| t.done(); | ||
| }), true); | ||
| </script> | ||
| <script> | ||
| this_is_a_js_error | ||
| </script> |
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The checks for ParserCeated on the previous line (and elsewhere in this PR) are still incorrect.