Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upKeep same timestamp when replacing frame state #14664
Closed
Conversation
highfive
commented
Dec 21, 2016
|
Heads up! This PR modifies the following files:
|
|
Any ideas for a way to write a test for this? @asajeffrey |
|
A test would be in an iframe, load docs A then B then C, then go back, refresh, go back, go forwards. You should end up at B, but if the jsh order is messed up, you'll end up at C. |
|
|
|
Superseded by #14312 |
|
Might be worth doing this anyway a) because #14312 isn't the easiest PR to land, and b) to add a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cbrewster commentedDec 21, 2016
•
edited by larsbergstrom
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is