Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: update bindings #14667

Merged
merged 2 commits into from Dec 22, 2016
Merged

stylo: update bindings #14667

merged 2 commits into from Dec 22, 2016

Conversation

@heycam
Copy link
Member

heycam commented Dec 22, 2016

@highfive
Copy link

highfive commented Dec 22, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/gecko_string_cache/atom_macro.rs, components/style/gecko_bindings/structs_release.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/gecko_string_cache/atom_macro.rs, components/style/gecko_bindings/structs_release.rs
@highfive
Copy link

highfive commented Dec 22, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bholley
Copy link
Contributor

bholley commented Dec 22, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

📌 Commit 2f81e8d has been approved by bholley

@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

Testing commit 2f81e8d with merge 1b069de...

bors-servo added a commit that referenced this pull request Dec 22, 2016
stylo: update bindings

<!-- Please describe your changes on the following line: -->

Update bindings for https://treeherder.mozilla.org/#/jobs?repo=stylo&revision=3cefc3d84bae6c9ae9d591bb26d98a8f6fc51d47.

r? @bholley

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14667)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

💔 Test failed - linux-rel-wpt

@heycam
Copy link
Member Author

heycam commented Dec 22, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

Previous build results for android, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev are reusable. Rebuilding only arm32, linux-rel-wpt...

@bholley
Copy link
Contributor

bholley commented Dec 22, 2016

Looks WR related:

CRASH [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-query-fragment-components.html

│ VMware, Inc.
│ Gallium 0.4 on softpipe
│ 3.3 (Core Profile) Mesa 12.0.1
│ called Result::unwrap() on an Err value: Error { repr: Custom(Custom { kind: UnexpectedEof, error: StringError("failed to fill whole buffer") }) } (thread , at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libcore/result.rs:837)
│ stack backtrace:
│ 0: 0x7fb3e2fe2e3d - backtrace::backtrace::trace::h7c3311890fb811f9
│ 1: 0x7fb3e2fe34d2 - backtrace::capture::Backtrace:🆕:h023332005d95d7ee
│ 2: 0x7fb3e2f0e73d - servo::main::_{{closure}}::hdf04f97b4a2ecfbe
│ 3: 0x7fb3e4d038e4 - std::panicking::rust_panic_with_hook
│ at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:554
│ 4: 0x7fb3e4d037a4 - std::panicking::begin_paniccollections::string::String
│ at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:515
│ 5: 0x7fb3e4d036c9 - std::panicking::begin_panic_fmt
│ at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:499
│ 6: 0x7fb3e4d03657 - std::panicking::rust_begin_panic
│ at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:475
│ 7: 0x7fb3e4d30b0d - core::panicking::panic_fmt
│ at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libcore/panicking.rs:69
│ 8: 0x7fb3e30ac53b - core::result::unwrap_failed::h0206fc1f464e719e
│ 9: 0x7fb3e30f1d86 - webrender::render_backend::RenderBackend::run::hc4d5b186fa3be790
│ 10: 0x7fb3e309e9f5 - std::panicking::try::do_call::h3afc7379fc990a65
│ 11: 0x7fb3e4d0a82a - panic_unwind::__rust_maybe_catch_panic
│ at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libpanic_unwind/lib.rs:98
│ 12: 0x7fb3e30b7264 - _<F as alloc..boxed..FnBox>::call_box::h10a4783a0ed5b87a
│ 13: 0x7fb3e4d02584 - alloc::boxed::{{impl}}::call_once<(),()>
│ at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/liballoc/boxed.rs:615
│ - std::sys_common:🧵:start_thread
│ at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/sys_common/thread.rs:21
│ - std::sys:👿🧵:{{impl}}:🆕:thread_start
│ at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/sys/unix/thread.rs:84
│ 14: 0x7fb3e0dea183 - start_thread
│ 15: 0x7fb3e090137c - clone
│ 16: 0x0 -
│ ERROR:servo: called Result::unwrap() on an Err value: Error { repr: Custom(Custom { kind: UnexpectedEof, error: StringError("failed to fill whole buffer") }) }
└ Pipeline failed in hard-fail mode. Crashing!

@glennw Should this be filed as a normal intermittent, or is this a test that just got unlucky?

@heycam
Copy link
Member Author

heycam commented Dec 22, 2016

Is this #14323?

@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

@bors-servo bors-servo merged commit 2f81e8d into servo:master Dec 22, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.