Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused dependency of style to plugins. #14671

Merged
merged 1 commit into from Dec 22, 2016
Merged

Remove the unused dependency of style to plugins. #14671

merged 1 commit into from Dec 22, 2016

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Dec 22, 2016 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@SimonSapin
Remove the unused dependency of style to plugins.
Loading status checks…
6dec458
@highfive
Copy link

highfive commented Dec 22, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml, components/style/lib.rs
  • @emilio: components/style/Cargo.toml, components/style/lib.rs
@highfive
Copy link

highfive commented Dec 22, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Dec 22, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

📌 Commit 6dec458 has been approved by emilio
@highfive highfive assigned emilio and unassigned mbrubeck Dec 22, 2016
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 22, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #14670
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

📌 Commit 6dec458 has been approved by mbrubeck
@highfive highfive assigned mbrubeck and unassigned emilio Dec 22, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

⌛ Testing commit 6dec458 with merge 4052744...
bors-servo added a commit that referenced this pull request Dec 22, 2016
@bors-servo
Auto merge of #14671 - servo:style-no-plugins, r=mbrubeck
Loading status checks…
4052744 
Remove the unused dependency of style to plugins.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14671)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Dec 22, 2016
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Dec 22, 2016

☀️ Test successful - arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-dev
@bors-servo bors-servo merged commit 6dec458 into master Dec 22, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the style-no-plugins branch Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@SimonSapin @highfive @emilio @bors-servo @mbrubeck
You can’t perform that action at this time.