Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regen bindings #14684

Merged
merged 1 commit into from Dec 23, 2016
Merged

Regen bindings #14684

merged 1 commit into from Dec 23, 2016

Conversation

@Manishearth
Copy link
Member

Manishearth commented Dec 23, 2016 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented Dec 23, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/gecko_string_cache/atom_macro.rs
  • @emilio: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/gecko_string_cache/atom_macro.rs
@highfive
Copy link

highfive commented Dec 23, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth Manishearth force-pushed the Manishearth:regen branch from 5d41840 to 375c70f Dec 23, 2016
@bholley
Copy link
Contributor

bholley commented Dec 23, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

📌 Commit 375c70f has been approved by bholley
@highfive highfive assigned bholley and unassigned metajack Dec 23, 2016
@heycam
Copy link
Member

heycam commented Dec 23, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #14679
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

📌 Commit 375c70f has been approved by heycam
@highfive highfive assigned heycam and unassigned bholley Dec 23, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

⌛ Testing commit 375c70f with merge a461adf...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

💔 Test failed - mac-rel-css
@Manishearth
Copy link
Member Author

Manishearth commented Dec 23, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

⌛ Testing commit 375c70f with merge 0db7fef...
bors-servo added a commit that referenced this pull request Dec 23, 2016
@bors-servo
Auto merge of #14684 - Manishearth:regen, r=heycam
Loading status checks…
0db7fef 
Regen bindings

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14684)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

💔 Test failed - mac-dev-unit
@heycam
Copy link
Member

heycam commented Dec 23, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

⚡ Previous build results for android, arm64, linux-rel-css, linux-rel-wpt, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev are reusable. Rebuilding only arm32, linux-dev, mac-dev-unit, mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

💔 Test failed - linux-dev
@Manishearth
Regen bindings
Loading status checks…
211682a
@Manishearth Manishearth force-pushed the Manishearth:regen branch from 375c70f to 211682a Dec 23, 2016
@Manishearth
Copy link
Member Author

Manishearth commented Dec 23, 2016

@bors-servo r=bholley

libloading ends up twice in the lockfile but there's a long chain of deps to get to it.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

📌 Commit 211682a has been approved by bholley
@highfive highfive assigned bholley and unassigned heycam Dec 23, 2016
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

⌛ Testing commit 211682a with merge dd2aa41...
bors-servo added a commit that referenced this pull request Dec 23, 2016
@bors-servo
Auto merge of #14684 - Manishearth:regen, r=bholley
Loading status checks…
dd2aa41 
Regen bindings

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14684)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

💔 Test failed - mac-rel-wpt1
@Manishearth
Copy link
Member Author

Manishearth commented Dec 23, 2016

@bors-servo retry

  • CI ded
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-gnu-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-wpt1...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev
@bors-servo bors-servo merged commit 211682a into servo:master Dec 23, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Dec 23, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bholley bholley

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@Manishearth @highfive @bholley @bors-servo @heycam @metajack
You can’t perform that action at this time.