Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upConstellation documentation comments #14698
Merged
Conversation
|
cc @Ms2ger. r? @ConnorGBrewster |
|
Looks good other than a couple nits. |
| } | ||
| } | ||
| /// Whether the constellation supports the clipboard. | ||
| /// TODO: this field is not used, remove it? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| /// Represents a pending change in the frame tree, that will be applied | ||
| /// once the new pipeline has loaded and completed initial layout / paint. | ||
| struct FrameChange { | ||
| /// The frame to change. | ||
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -684,6 +877,8 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF> | |||
| } | |||
| } | |||
|
|
|||
| /// The joint session future is the merge of the session future of every | |||
| /// frame in the frame tree, sorted chronologically. | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
asajeffrey
force-pushed the
asajeffrey:constellation-docs
branch
from
52ce028
to
1fbb23d
|
Squashed. @bors-servo r=ConnorGBrewster |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 23, 2016
Constellation documentation comments <!-- Please describe your changes on the following line: --> Rewrote the documentation comments for `constellation.rs`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's just documentation <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14698) <!-- Reviewable:end -->
|
|
|
@bors-servo retry
|
bors-servo
added a commit
that referenced
this pull request
Dec 23, 2016
Constellation documentation comments <!-- Please describe your changes on the following line: --> Rewrote the documentation comments for `constellation.rs`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's just documentation <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14698) <!-- Reviewable:end -->
|
|
|
@jdm says this is servo/saltfs#565 |
|
YOLO @bors-servo retry |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Dec 24, 2016
Constellation documentation comments <!-- Please describe your changes on the following line: --> Rewrote the documentation comments for `constellation.rs`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes do not require tests because it's just documentation <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14698) <!-- Reviewable:end -->
|
|
This was referenced Dec 24, 2016
| } | ||
|
|
||
| /// Stores the navigation context for a single frame in the frame tree. | ||
| /// A frame in the frame tree. | ||
| /// Each frame is the constrellation's view of a browsing context. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedDec 23, 2016
•
edited by larsbergstrom
Rewrote the documentation comments for
constellation.rs../mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is