Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix to avoid attribute name clash between Document/HTMLDocument #1472
Conversation
hoppipolla-critic-bot
commented
Jan 8, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/534 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
LGTM. @jdm? |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging brunoabinader/servo/document-head = b5eba00 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = e8b0eae |
b5eba00
into
servo:master
brunoabinader commentedJan 8, 2014
Use children() instead of traverse_preorder(), and avoid having
GetHead() in both Document and HTMLDocument.
Closes #1465.