Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to avoid attribute name clash between Document/HTMLDocument #1472

Merged
merged 1 commit into from Jan 8, 2014

Conversation

@brunoabinader
Copy link
Contributor

brunoabinader commented Jan 8, 2014

Use children() instead of traverse_preorder(), and avoid having
GetHead() in both Document and HTMLDocument.

Closes #1465.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 8, 2014

Critic review: https://critic.hoppipolla.co.uk/r/534

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Use children() instead of traverse_preorder(), and avoid having
GetHead() in both Document and HTMLDocument.

Closes #1465.
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 8, 2014

LGTM. @jdm?

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on b5eba00 Jan 8, 2014

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jan 8, 2014

merging brunoabinader/servo/document-head = b5eba00 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jan 8, 2014

brunoabinader/servo/document-head = b5eba00 merged ok, testing candidate = e8b0eae

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jan 8, 2014

fast-forwarding master to auto = e8b0eae

bors-servo pushed a commit that referenced this pull request Jan 8, 2014
Use children() instead of traverse_preorder(), and avoid having
GetHead() in both Document and HTMLDocument.

Closes #1465.
@bors-servo bors-servo closed this Jan 8, 2014
@bors-servo bors-servo merged commit b5eba00 into servo:master Jan 8, 2014
1 check passed
1 check passed
default all tests passed
@brunoabinader brunoabinader deleted the brunoabinader:document-head branch Jan 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.