Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bindgenup #14721

Merged
merged 4 commits into from Dec 25, 2016
Merged

Bindgenup #14721

merged 4 commits into from Dec 25, 2016

Conversation

@emilio
Copy link
Member

emilio commented Dec 25, 2016 •
edited by larsbergstrom

r? @Manishearth

This change is Reviewable
emilio added 4 commits Dec 25, 2016
@emilio
Update libbindgen.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
0b1ae16
@emilio
style: Update bindings because of bug 1325006
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
f08e851
@emilio
stylo: Copy binding files even if the build failed.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
1934219 
It's easier to stash the changes away than to find the generated files.
@emilio
stylo: Regen bindings.
Unverified
This user has not uploaded their public key yet.
GPG key ID: 056B727BB9C1027C Learn about signing commits
Loading status checks…
bf53447
@highfive
Copy link

highfive commented Dec 25, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/gecko/values.rs
  • @wafflespeanut: python/servo/build_commands.py
@highfive
Copy link

highfive commented Dec 25, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth
Copy link
Member

Manishearth commented Dec 25, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 25, 2016

📌 Commit bf53447 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Dec 25, 2016

⌛ Testing commit bf53447 with merge 75b3d68...
bors-servo added a commit that referenced this pull request Dec 25, 2016
@bors-servo
Auto merge of #14721 - emilio:bindgenup, r=Manishearth
Loading status checks…
75b3d68 
Bindgenup

<!-- Please describe your changes on the following line: -->
r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14721)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 25, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit bf53447 into servo:master Dec 25, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Dec 25, 2016
Closed
@emilio emilio deleted the emilio:bindgenup branch Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@emilio @highfive @Manishearth @bors-servo
You can’t perform that action at this time.