Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse typed array in TextDecoder::Decode #14727
Merged
+5
−5
Conversation
highfive
commented
Dec 25, 2016
highfive
commented
Dec 25, 2016
|
|
Cargo.lock
Outdated
| @@ -1246,7 +1246,7 @@ dependencies = [ | |||
| [[package]] | |||
| name = "js" | |||
| version = "0.1.3" | |||
| source = "git+https://github.com/servo/rust-mozjs#342f304a455080acf64f5ceb40a7f8059481ca01" | |||
| source = "git+https://github.com/servo/rust-mozjs#15ff1e83446e998112dcde731610e8b60cc32abf" | |||
This comment has been minimized.
This comment has been minimized.
wafflespeanut
Dec 27, 2016
•
Member
Hm, we already seem to be using this revision in master. Rebase?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zaynetro
force-pushed the
zaynetro:textdecoder-use-typedarray
branch
from
22da7c7
to
40fa021
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 27, 2016
Use typed array in TextDecoder::Decode <!-- Please describe your changes on the following line: --> Use typed array API in TextDecoder::Decode --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #14674 <!-- Either: --> - [x] These changes do not require tests because no new methods were introduced <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14727) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zaynetro commentedDec 25, 2016
•
edited by larsbergstrom
Use typed array API in TextDecoder::Decode
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is