Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Crypto::GetRandomValues to use typed array API #14730

Merged
merged 1 commit into from Dec 26, 2016
Merged

Rewrite Crypto::GetRandomValues to use typed array API #14730

merged 1 commit into from Dec 26, 2016

Conversation

@yysung1123
Copy link
Contributor

yysung1123 commented Dec 25, 2016 •
edited

Rewrite Crypto::GetRandomValues to use typed array API

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #14673 (github issue number if applicable).
  • There are tests for these changes

This change is Reviewable
@highfive
Copy link

highfive commented Dec 25, 2016

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon.
@highfive
Copy link

highfive commented Dec 25, 2016

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/crypto.rs
  • @KiChjang: components/script/dom/crypto.rs
@highfive
Copy link

highfive commented Dec 25, 2016

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@yysung1123 yysung1123 changed the title Rewrite Crypto::GetRandomValues to use typed array API [WIP] Rewrite Crypto::GetRandomValues to use typed array API Dec 25, 2016
@yysung1123 yysung1123 force-pushed the yysung1123:typed_array_API branch from ebb78d0 to 11ec44b Dec 25, 2016
@yysung1123 yysung1123 changed the title [WIP] Rewrite Crypto::GetRandomValues to use typed array API Rewrite Crypto::GetRandomValues to use typed array API Dec 25, 2016
@yysung1123
Rewrite Crypto::GetRandomValues to use typed array API
Loading status checks…
684db8b 
Fix mut typed_array

Redundant code
@yysung1123 yysung1123 force-pushed the yysung1123:typed_array_API branch from 11ec44b to 684db8b Dec 26, 2016
@emilio
Copy link
Member

emilio commented Dec 26, 2016

Looks good to me, thanks!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 26, 2016

📌 Commit 684db8b has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Dec 26, 2016

⌛ Testing commit 684db8b with merge 1c60a5b...
bors-servo added a commit that referenced this pull request Dec 26, 2016
@bors-servo
Auto merge of #14730 - deror1869107:typed_array_API, r=emilio
Loading status checks…
1c60a5b 
Rewrite Crypto::GetRandomValues to use typed array API

<!-- Please describe your changes on the following line: -->
Rewrite Crypto::GetRandomValues to use typed array API

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes fix #14673  (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14730)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 26, 2016

💔 Test failed - linux-rel-css
@KiChjang
Copy link
Member

KiChjang commented Dec 26, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 26, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-css...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 26, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit 684db8b into servo:master Dec 26, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@yysung1123 yysung1123 deleted the yysung1123:typed_array_API branch Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Rewrite Crypto::GetRandomValues to use typed array API
5 participants
@yysung1123 @highfive @emilio @bors-servo @KiChjang
You can’t perform that action at this time.