Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse the http connector pool between fetches #14741

Merged
merged 1 commit into from Dec 27, 2016
Merged

Reuse the http connector pool between fetches #14741

merged 1 commit into from Dec 27, 2016

Conversation

mattnenterprise
Copy link
Contributor

@mattnenterprise mattnenterprise commented Dec 27, 2016


  • There are tests for these changes

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/resource_thread.rs, components/net/http_loader.rs

@highfive
Copy link

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Dec 27, 2016
@jdm
Copy link
Member

jdm commented Dec 27, 2016

@bors-servo: r+
Thanks!

@bors-servo
Copy link
Contributor

📌 Commit ed075ab has been approved by jdm

@highfive highfive assigned jdm and unassigned wafflespeanut Dec 27, 2016
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Dec 27, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit ed075ab with merge 5d180af...

bors-servo pushed a commit that referenced this pull request Dec 27, 2016
Reuse the http connector pool between fetches

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14697

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14741)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Dec 27, 2016
@bors-servo
Copy link
Contributor

⌛ Testing commit ed075ab with merge 7e3c9e2...

bors-servo pushed a commit that referenced this pull request Dec 27, 2016
Reuse the http connector pool between fetches

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14697

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14741)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Dec 27, 2016
@bors-servo
Copy link
Contributor

@bors-servo bors-servo merged commit ed075ab into servo:master Dec 27, 2016
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Dec 27, 2016
@bors-servo bors-servo mentioned this pull request Dec 27, 2016
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HTTP connector to HttpState, instead of creating one in http_network_fetch
5 participants