Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse the http connector pool between fetches #14741

Merged
merged 1 commit into from Dec 27, 2016
Merged

Conversation

@mattnenterprise
Copy link
Contributor

mattnenterprise commented Dec 27, 2016


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #14697
  • There are tests for these changes

This change is Reviewable

@highfive
Copy link

highfive commented Dec 27, 2016

Heads up! This PR modifies the following files:

  • @KiChjang: components/net/resource_thread.rs, components/net/http_loader.rs
@highfive
Copy link

highfive commented Dec 27, 2016

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Dec 27, 2016

@bors-servo: r+
Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Dec 27, 2016

📌 Commit ed075ab has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Dec 27, 2016

Testing commit ed075ab with merge 5d180af...

bors-servo added a commit that referenced this pull request Dec 27, 2016
Reuse the http connector pool between fetches

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14697

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14741)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 27, 2016

💔 Test failed - linux-rel-wpt

@jdm
Copy link
Member

jdm commented Dec 27, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Dec 27, 2016

Testing commit ed075ab with merge 7e3c9e2...

bors-servo added a commit that referenced this pull request Dec 27, 2016
Reuse the http connector pool between fetches

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14697

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14741)
<!-- Reviewable:end -->
@bors-servo bors-servo merged commit ed075ab into servo:master Dec 27, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Dec 27, 2016
4 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants
You can’t perform that action at this time.