Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove frame from constellation #14744
Merged
Conversation
highfive
commented
Dec 27, 2016
|
Heads up! This PR modifies the following files:
|
yysung1123
force-pushed the
yysung1123:move_frame_from_constellation
branch
from
55138bb
to
d53f640
|
@bors-servo r+ Thanks for working on this :) |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 27, 2016
…Wafflespeanut Move frame from constellation <!-- Please describe your changes on the following line: --> Move frame from constellation --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #14691 (github issue number if applicable). <!-- Either: --> - [X] These changes do not require tests <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
|
|
That was fast, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yysung1123 commentedDec 27, 2016
Move frame from constellation
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors