Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBuild with debugmozjs to run automated tests #14766
Closed
Conversation
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Dec 28, 2016
…try> Build with debugmozjs to run automated tests This will enable many safety checks which will ease diagnosing problems. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [x] These changes fix #14759 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because changes the build steps <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> I've only enabled it for builds that are followed by `test-wpt` or `test-css` steps. I'm not sure if this also needs to be enabled for subsequent `build-cef` and `build-geckolib` steps on the same builder to avoid rebuilding crates due to a feature mismatch. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14766) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Dec 29, 2016
…try> Build with debugmozjs to run automated tests This will enable many safety checks which will ease diagnosing problems. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [x] These changes fix #14759 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because changes the build steps <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> I've only enabled it for builds that are followed by `test-wpt` or `test-css` steps. I'm not sure if this also needs to be enabled for subsequent `build-cef` and `build-geckolib` steps on the same builder to avoid rebuilding crates due to a feature mismatch. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14766) <!-- Reviewable:end -->
|
|
|
Same failures on the mac builders and the linux builder both times. Interesting. |
|
Added a fixup commit per #14759 (comment). @Ms2ger do you know if |
|
I doubt that commit makes a difference, but the queue is nearly empty. @bors-servo retry |
|
@bors-servo: try |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 4, 2017
…try> Build with debugmozjs to run automated tests This will enable many safety checks which will ease diagnosing problems. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [x] These changes fix #14759 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because changes the build steps <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> I've only enabled it for builds that are followed by `test-wpt` or `test-css` steps. I'm not sure if this also needs to be enabled for subsequent `build-cef` and `build-geckolib` steps on the same builder to avoid rebuilding crates due to a feature mismatch. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14766) <!-- Reviewable:end -->
|
|
|
|
|
build-cef should probably be modified to accept --debug-mozjs, however. |
|
I can't help thinking that a |
This will enable many safety checks which will ease diagnosing problems. Teach `build-cef` about the `--debug-mozjs` flag.
aneeshusa
force-pushed the
aneeshusa:build-with-debugmozjs-for-tests
branch
from
40b4784
to
ba139de
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jan 4, 2017
…try> Build with debugmozjs to run automated tests This will enable many safety checks which will ease diagnosing problems. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [x] These changes fix #14759 (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [x] These changes do not require tests because changes the build steps <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> I've only enabled it for builds that are followed by `test-wpt` or `test-css` steps. I'm not sure if this also needs to be enabled for subsequent `build-cef` and `build-geckolib` steps on the same builder to avoid rebuilding crates due to a feature mismatch. r? @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14766) <!-- Reviewable:end -->
|
|
|
That looks kind of like jsapi_windows_msvc14_64_debug.rs is incorrect. @vvuk Any idea what's going on in the previous failure? |
|
|
Not offhand :( Unfortunately I'm about to get on a flight so can't check,
but will do so as soon as I can.
|
|
Any update, @vvuk? |
|
When mozjs is built with debugging, it expects to link to the debug versions of the MSVC CRT (specifically, |
|
Filed rust-lang/rust#39016. |
This was referenced Jan 27, 2017
|
I'm going to go ahead and close this until we solve the Windows problem. Thanks for investigating it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
aneeshusa commentedDec 28, 2016
•
edited by larsbergstrom
This will enable many safety checks which will ease diagnosing problems.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsI've only enabled it for builds that are followed by
test-wptortest-csssteps.I'm not sure if this also needs to be enabled for subsequent
build-cefandbuild-geckolibsteps on the same builder to avoid rebuilding crates due to a feature mismatch.r? @jdm
This change is