Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libbindgen to 0.1.5 #14768

Merged
merged 1 commit into from Dec 29, 2016
Merged

Upgrade libbindgen to 0.1.5 #14768

merged 1 commit into from Dec 29, 2016

Conversation

@upsuper
Copy link
Member

upsuper commented Dec 29, 2016 •
edited by larsbergstrom

0.1.4 is known to be broken on Windows, and earlier version may not work properly in various platforms.

r? @emilio

This change is Reviewable
@upsuper
Upgrade libbindgen to 0.1.5
Loading status checks…
f1f1466 
0.1.4 is known for being broken on Windows, and earlier version may not
work properly in various platforms.
@highfive
Copy link

highfive commented Dec 29, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml
  • @emilio: components/style/Cargo.toml
@highfive
Copy link

highfive commented Dec 29, 2016

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented Dec 29, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

📌 Commit f1f1466 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

⌛ Testing commit f1f1466 with merge 5d7e420...
bors-servo added a commit that referenced this pull request Dec 29, 2016
@bors-servo
Auto merge of #14768 - upsuper:upgrade-bindgen, r=emilio
Loading status checks…
5d7e420 
Upgrade libbindgen to 0.1.5

0.1.4 is known to be broken on Windows, and earlier version may not work properly in various platforms.

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14768)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

💔 Test failed - linux-dev
@upsuper
Copy link
Member Author

upsuper commented Dec 29, 2016

The failure doesn't seem to be related at all...
@upsuper
Copy link
Member Author

upsuper commented Dec 29, 2016

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

⌛ Testing commit f1f1466 with merge ab623de...
bors-servo added a commit that referenced this pull request Dec 29, 2016
@bors-servo
Auto merge of #14768 - upsuper:upgrade-bindgen, r=emilio
Loading status checks…
ab623de 
Upgrade libbindgen to 0.1.5

0.1.4 is known to be broken on Windows, and earlier version may not work properly in various platforms.

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14768)
<!-- Reviewable:end -->
@emilio
Copy link
Member

emilio commented Dec 29, 2016

Yeah, was filling, failure is #14774
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

💔 Test failed - mac-rel-wpt2
@emilio emilio mentioned this pull request Dec 29, 2016
Closed
@emilio
Copy link
Member

emilio commented Dec 29, 2016

@bors-servo retry #14775
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

⚡ Previous build results for arm32, arm64, linux-dev, mac-dev-unit, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only android, linux-rel-css, linux-rel-wpt, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

💔 Test failed - linux-rel-css
@upsuper upsuper mentioned this pull request Dec 29, 2016
Closed
@upsuper
Copy link
Member Author

upsuper commented Dec 29, 2016

@bors-servo retry #14777
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 29, 2016

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit f1f1466 into servo:master Dec 29, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@upsuper upsuper deleted the upsuper-forks:upgrade-bindgen branch Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@upsuper @highfive @emilio @bors-servo
You can’t perform that action at this time.