Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstylo: Don't persist styles on elements not in the document. #14776
Conversation
highfive
commented
Dec 29, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Dec 29, 2016
|
|
|
@bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 29, 2016
stylo: Don't persist styles on elements not in the document. <!-- Please describe your changes on the following line: --> This is the Servo half of https://bugzilla.mozilla.org/show_bug.cgi?id=1324983, which @emilio has already reviewed. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14776) <!-- Reviewable:end -->
|
|
components/script/layout_wrapper.rs
Outdated
| @@ -199,6 +199,10 @@ impl<'ln> TNode for ServoLayoutNode<'ln> { | |||
| self.node.parent_node_ref().map(|node| self.new_with_this_lifetime(&node)) | |||
| } | |||
| } | |||
|
|
|||
| fn is_in_doc(&self) -> bool { | |||
| self.node.is_in_doc() | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=emilio |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 30, 2016
stylo: Don't persist styles on elements not in the document. <!-- Please describe your changes on the following line: --> This is the Servo half of https://bugzilla.mozilla.org/show_bug.cgi?id=1324983, which @emilio has already reviewed. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14776) <!-- Reviewable:end -->
|
|
|
Nit: since the style system operates almost exclusively on elements, methods should go on TElement unless we have an active consumer that needs the method on TNode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
heycam commentedDec 29, 2016
•
edited by larsbergstrom
This is the Servo half of https://bugzilla.mozilla.org/show_bug.cgi?id=1324983, which @emilio has already reviewed.
This change is