Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate UA stylesheets for lists #1478
Conversation
hoppipolla-critic-bot
commented
Jan 13, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/544 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Eventually I wish we could base our UA stylesheet on the Rendering section of the spec, but unfortunately so much of it is written in prose rather than CSS. Maybe we could still express that prose in CSS with additional internal-only keywords, or something. In the meantime, this looks fine. This is adding style for the obsolete |
This comment has been minimized.
This comment has been minimized.
SimonSapin
commented on 0d8ee06
Jan 13, 2014
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from SimonSapin |
This comment has been minimized.
This comment has been minimized.
|
merging recrack/servo/useragentcss = 0d8ee06 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
all tests pass: |
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = 0489292 |
#1232 Servo UA (http://www.w3.org/TR/CSS21/sample.html) This is UA css from http://mxr.mozilla.org/mozilla/source/layout/style/html.css and http://dev.w3.org/csswg/css-lists/#ua-stylesheet ``` ul margin-left: 40px -> padding-left: 40px ol margin-left: 40px -> padding-left: 40px ```
|
@SimonSapin Thanks. This reference site is very helpful for me. (http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html) |
0d8ee06
into
servo:master
recrack commentedJan 13, 2014
#1232
Servo UA (http://www.w3.org/TR/CSS21/sample.html)
This is UA css from http://mxr.mozilla.org/mozilla/source/layout/style/html.css and http://dev.w3.org/csswg/css-lists/#ua-stylesheet