Skip to content

Comments

Update UA stylesheets for lists#1478

Merged
bors-servo merged 1 commit intoservo:masterfrom
recrack:useragentcss
Jan 13, 2014
Merged

Update UA stylesheets for lists#1478
bors-servo merged 1 commit intoservo:masterfrom
recrack:useragentcss

Conversation

@recrack
Copy link

@recrack recrack commented Jan 13, 2014

#1232

Servo UA (http://www.w3.org/TR/CSS21/sample.html)

This is UA css from http://mxr.mozilla.org/mozilla/source/layout/style/html.css and http://dev.w3.org/csswg/css-lists/#ua-stylesheet

ul margin-left: 40px -> padding-left: 40px
ol margin-left: 40px -> padding-left: 40px

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/544

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@SimonSapin
Copy link
Member

Eventually I wish we could base our UA stylesheet on the Rendering section of the spec, but unfortunately so much of it is written in prose rather than CSS. Maybe we could still express that prose in CSS with additional internal-only keywords, or something.

In the meantime, this looks fine. This is adding style for the obsolete <multicol> element, but that shouldn’t be harmful.

bors-servo pushed a commit that referenced this pull request Jan 13, 2014
@recrack
Copy link
Author

recrack commented Jan 13, 2014

@SimonSapin Thanks. This reference site is very helpful for me. (http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html)

@bors-servo bors-servo merged commit 0d8ee06 into servo:master Jan 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants