Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UA stylesheets for lists #1478

Merged
merged 1 commit into from Jan 13, 2014
Merged

Update UA stylesheets for lists #1478

merged 1 commit into from Jan 13, 2014

Conversation

@recrack
Copy link
Contributor

recrack commented Jan 13, 2014

#1232

Servo UA (http://www.w3.org/TR/CSS21/sample.html)

This is UA css from http://mxr.mozilla.org/mozilla/source/layout/style/html.css and http://dev.w3.org/csswg/css-lists/#ua-stylesheet

ul margin-left: 40px -> padding-left: 40px
ol margin-left: 40px -> padding-left: 40px
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 13, 2014

Critic review: https://critic.hoppipolla.co.uk/r/544

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@SimonSapin
Copy link
Member

SimonSapin commented Jan 13, 2014

Eventually I wish we could base our UA stylesheet on the Rendering section of the spec, but unfortunately so much of it is written in prose rather than CSS. Maybe we could still express that prose in CSS with additional internal-only keywords, or something.

In the meantime, this looks fine. This is adding style for the obsolete <multicol> element, but that shouldn’t be harmful.

@SimonSapin

This comment has been minimized.

Copy link

SimonSapin commented on 0d8ee06 Jan 13, 2014

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 0d8ee06 Jan 13, 2014

saw approval from SimonSapin
at recrack@0d8ee06

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jan 13, 2014

merging recrack/servo/useragentcss = 0d8ee06 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jan 13, 2014

recrack/servo/useragentcss = 0d8ee06 merged ok, testing candidate = 0489292

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jan 13, 2014

fast-forwarding master to auto = 0489292

bors-servo pushed a commit that referenced this pull request Jan 13, 2014
@recrack
Copy link
Contributor Author

recrack commented Jan 13, 2014

@SimonSapin Thanks. This reference site is very helpful for me. (http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html)

@bors-servo bors-servo merged commit 0d8ee06 into servo:master Jan 13, 2014
1 check passed
1 check passed
default all tests passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.