Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[DO NOT MERGE] Initiate image loads in the script thread #14781
Closed
+713
−1,571
Conversation
highfive
commented
Dec 29, 2016
|
Heads up! This PR modifies the following files:
|
highfive
commented
Dec 29, 2016
|
|
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Dec 29, 2016
[DO NOT MERGE] Initiate image loads in the script thread I just want to do some try runs. This is still very much work-in-progress.
|
|
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Dec 29, 2016
[DO NOT MERGE] Initiate image loads in the script thread I just want to do some try runs. This is still very much work-in-progress. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14781) <!-- Reviewable:end -->
|
|
|
linux-rel-wpt: mac-rel-wpt2: |
|
|
|
@bors-servo: try |
bors-servo
added a commit
that referenced
this pull request
Jan 4, 2017
[DO NOT MERGE] Initiate image loads in the script thread I just want to do some try runs. This is still very much work-in-progress. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14781) <!-- Reviewable:end -->
|
|
|
@bors-servo: r- |
|
@bors-servo: try |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 6, 2017
[DO NOT MERGE] Initiate image loads in the script thread I just want to do some try runs. This is still very much work-in-progress. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14781) <!-- Reviewable:end -->
|
|
|
gl-teximage passed that time :O |
|
@bors-servo: retry |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 6, 2017
[DO NOT MERGE] Initiate image loads in the script thread I just want to do some try runs. This is still very much work-in-progress. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14781) <!-- Reviewable:end -->
|
|
|
Only test-tidy has failed for two try runs in a row. I guess it's time to clean this up into something mergeable! |
|
|
In support of this goal, the layout thread collects information about CSS images that are missing image data and hands it off to the script thread after layout completes. The script thread stores a list of nodes that will need to be reflowed after the associated network request is complete. The script thread ensures that the nodes are not GCed while a request is ongoing, which the layout thread is incapable of guaranteeing. The image cache's API has also been redesigned in support of this work. No network requests are made by the new image cache, since it does not possess the document-specific information necessary to initiate them. Instead, there is now a single, synchronous query operation that optionally reserves a slot when a cache entry for a URL cannot be found. This reserved slot is then the responsibility of the queryer to populate with the contents of the network response for the URL once it is complete. Any subsequent queries for the same URL will be informed that the response is pending until that occurs. The changes to layout also remove the synchronous image loading code path, which means that reftests now test the same code that non-test binaries execute. The decision to take a screenshot now considers whether there are any outstanding image requests for layout in order to avoid intermittent failures in reftests that use CSS images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedDec 29, 2016
•
edited by larsbergstrom
I just want to do some try runs. This is still very much work-in-progress.
This change is