Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Support at-import. #14793

Merged
merged 2 commits into from Dec 31, 2016
Merged

stylo: Support at-import. #14793

merged 2 commits into from Dec 31, 2016

Conversation

@emilio
Copy link
Member

emilio commented Dec 30, 2016

Reviewed upstream by @heycam and @Manishearth in:

https://bugzilla.mozilla.org/show_bug.cgi?id=1304792


This change is Reviewable

emilio added 2 commits Dec 17, 2016
MozReview-Commit-ID: Hw1V66JxIBD
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
…heycam

MozReview-Commit-ID: HKjsOaE2qAp
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
@highfive
Copy link

highfive commented Dec 30, 2016

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/bindings.rs, components/style/gecko_bindings/structs_debug.rs, components/style/build_gecko.rs, components/style/gecko_bindings/structs_release.rs, components/style/gecko_bindings/sugar/ownership.rs, components/style/gecko/conversions.rs
@highfive
Copy link

highfive commented Dec 30, 2016

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member Author

emilio commented Dec 31, 2016

@bors-servo r=heycam,Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Dec 31, 2016

📌 Commit df9da70 has been approved by heycam,Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Dec 31, 2016

Testing commit df9da70 with merge 569e61e...

bors-servo added a commit that referenced this pull request Dec 31, 2016
stylo: Support at-import.

Reviewed upstream by @heycam  and @Manishearth in:

https://bugzilla.mozilla.org/show_bug.cgi?id=1304792

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14793)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 31, 2016

💔 Test failed - linux-rel-css

@emilio
Copy link
Member Author

emilio commented Dec 31, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Dec 31, 2016

Previous build results for android, arm32, arm64, linux-dev, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev are reusable. Rebuilding only linux-rel-css...

@bors-servo bors-servo merged commit df9da70 into servo:master Dec 31, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.