Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix rowspan handling for rows that span to the end of the rowgroup #14798
Conversation
| @@ -1,7 +1,6 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <meta charset="UTF-8"> | |||
| <link rel="match" href="table_rowspan_simple_ref.html"> | |||
This comment has been minimized.
This comment has been minimized.
| <!DOCTYPE html> | ||
| <html> | ||
| <meta charset="UTF-8"> | ||
| <link rel="match" href="table_rowspan_rowgroup_ref.html"> |
This comment has been minimized.
This comment has been minimized.
notriddle
Dec 31, 2016
Contributor
Could a <link rel="spec" href="https://html.spec.whatwg.org/multipage/tables.html#attributes-common-to-td-and-th-elements"> be a good idea here?
This comment has been minimized.
This comment has been minimized.
emilio
Dec 31, 2016
Member
I thought spec links used to be <link rel=help>, but I don't think it matters much anyway :)
|
Other than that, LGTM. |
|
@bors-servo r=notriddle
|
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 31, 2016
Fix rowspan handling for rows that span to the end of the rowgroup This fixes `rowspan="0"` to behave as described in [the HTML spec](https://html.spec.whatwg.org/multipage/tables.html#attributes-common-to-td-and-th-elements): > For this attribute, the value zero means that the cell is to span all the remaining rows in the row group. It also prevents any `rowspan` from overlapping into another rowgroup, as required by [HTML § 4.9.12](https://html.spec.whatwg.org/multipage/tables.html#table-processing-model): > Row groups cannot overlap each other. Similarly, column groups cannot overlap each other. A cell cannot cover slots that are from two or more row groups. r? @notriddle or @pcwalton --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14798) <!-- Reviewable:end -->
|
@bors-servo r=notriddle
|
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 31, 2016
Fix rowspan handling for rows that span to the end of the rowgroup This fixes `rowspan="0"` to behave as described in [the HTML spec](https://html.spec.whatwg.org/multipage/tables.html#attributes-common-to-td-and-th-elements): > For this attribute, the value zero means that the cell is to span all the remaining rows in the row group. It also prevents any `rowspan` from overlapping into another rowgroup, as required by [HTML § 4.9.12](https://html.spec.whatwg.org/multipage/tables.html#table-processing-model): > Row groups cannot overlap each other. Similarly, column groups cannot overlap each other. A cell cannot cover slots that are from two or more row groups. r? @notriddle or @pcwalton --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14798) <!-- Reviewable:end -->
|
|
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Dec 31, 2016
Fix rowspan handling for rows that span to the end of the rowgroup This fixes `rowspan="0"` to behave as described in [the HTML spec](https://html.spec.whatwg.org/multipage/tables.html#attributes-common-to-td-and-th-elements): > For this attribute, the value zero means that the cell is to span all the remaining rows in the row group. It also prevents any `rowspan` from overlapping into another rowgroup, as required by [HTML § 4.9.12](https://html.spec.whatwg.org/multipage/tables.html#table-processing-model): > Row groups cannot overlap each other. Similarly, column groups cannot overlap each other. A cell cannot cover slots that are from two or more row groups. r? @notriddle or @pcwalton --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14798) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedDec 30, 2016
•
edited by larsbergstrom
This fixes
rowspan="0"to behave as described in the HTML spec:It also prevents any
rowspanfrom overlapping into another rowgroup, as required by HTML § 4.9.12:r? @notriddle or @pcwalton
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is