Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Sub-resource integrity fetch step #14816
Closed
Conversation
nmvk
changed the title
|
r? @jdm |
Implemented step eighteen of main fetch. If a request has integrity metadata, then following steps are performed 1) Wait for response body 2) If response does not have a termination reason and response does not match request’s integrity metadata, set response and internalResponse to a network error. SRI document specifies that user-agent should support SHA256,384 and 512. Validation using unsupported hash functions acts like no integrity value was provided for this reason validate_response_integrity method returns true if hashing algorithm specified is not SHA256, 384, 512.Validation is performed on response this is specified in fetch specification.
nmvk
changed the title
|
Why'd you close the PR, @mrnayak? |
|
@jdm I got confused since I am sorry for the confusion. |
|
They do use fetch, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nmvk commentedJan 1, 2017
•
edited
Implemented step eighteen of the main fetch. If a request has integrity metadata, then following steps are performed
SRI document specifies that user-agent should support SHA256,384 and 512. Validation using unsupported hash functions acts like no integrity value was provided for this reason validate_response_integrity method returns true if hashing algorithm specified is not SHA256, 384, 512.Validation is performed on the response this is specified in fetch specification.
SRI document specified there could be multiple Integrity metadata in integrity attribute. I believe the best algorithm would have been selected and set in integrity metadata before the main fetch is called. Is my assumption correct here?
This will not completely fix #14523, It will implement changes related fetch part.
r? @jdm
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors.
This change is