Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browserhtml path #14829

Merged
merged 1 commit into from Jan 3, 2017
Merged

Fix browserhtml path #14829

merged 1 commit into from Jan 3, 2017

Conversation

@wafflespeanut
Copy link
Member

wafflespeanut commented Jan 3, 2017

I'd missed something in #14817, which now prevents us from running ./mach run -r -b. @UK992 pointed this in the PR, but it got merged soon 😐


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it's a fix for mach

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Jan 3, 2017

Heads up! This PR modifies the following files:

@wafflespeanut

This comment has been minimized.

Copy link
Member Author

wafflespeanut commented Jan 3, 2017

@bors-servo p=19263

@wafflespeanut

This comment has been minimized.

Copy link
Member Author

wafflespeanut commented Jan 3, 2017

@bors-servo r=UK992

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 3, 2017

📌 Commit b061ada has been approved by UK992

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jan 3, 2017

⌛️ Testing commit b061ada with merge 128aac9...

bors-servo added a commit that referenced this pull request Jan 3, 2017
Fix browserhtml path

<!-- Please describe your changes on the following line: -->

I'd missed something in #14817, which now prevents us from running `./mach run -r -b`. @UK992 pointed this in the PR, but it got merged soon 😐

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because it's a fix for mach

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14829)
<!-- Reviewable:end -->
@wafflespeanut wafflespeanut assigned wafflespeanut and unassigned Ms2ger Jan 3, 2017
@bors-servo

This comment has been minimized.

@bors-servo bors-servo merged commit b061ada into servo:master Jan 3, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@wafflespeanut wafflespeanut deleted the wafflespeanut:browserhtml branch Jan 3, 2017
@wafflespeanut wafflespeanut restored the wafflespeanut:browserhtml branch Jan 3, 2017
@wafflespeanut wafflespeanut deleted the wafflespeanut:browserhtml branch Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.