Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Document::doctype #1483

Merged
merged 1 commit into from Jan 13, 2014
Merged

Implement Document::doctype #1483

merged 1 commit into from Jan 13, 2014

Conversation

@brunoabinader
Copy link
Contributor

brunoabinader commented Jan 13, 2014

Closes #1482.
@brunoabinader brunoabinader reopened this Jan 13, 2014
@brunoabinader brunoabinader reopened this Jan 13, 2014
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jan 13, 2014

Critic review: https://critic.hoppipolla.co.uk/r/547

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@brunoabinader
Implement Document::doctype
Loading status checks…
742ad9c 
Closes #1482.
@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 13, 2014

r+
@bors-servo

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo commented on 742ad9c Jan 13, 2014

saw approval from jdm
at https://github.com/brunoabinader/servo/commit/742ad9cd24e240e4c4db312d2651fb57f056e07e

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 13, 2014

merging brunoabinader/servo/document-doctype = 742ad9c into auto

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 13, 2014

brunoabinader/servo/document-doctype = 742ad9c merged ok, testing candidate = 50b66f3

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 13, 2014

all tests pass:
success: http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/795
success: http://servo-buildbot.pub.build.mozilla.org/builders/mac/builds/750

This comment has been minimized.

Sign in to view
Copy link
Contributor

bors-servo replied Jan 13, 2014

fast-forwarding master to auto = 50b66f3
bors-servo pushed a commit that referenced this pull request Jan 13, 2014
bors-servo
auto merge of #1483 : brunoabinader/servo/document-doctype, r=jdm
50b66f3 
Closes #1482.
@bors-servo bors-servo merged commit 742ad9c into servo:master Jan 13, 2014
1 check passed
1 check passed
default all tests passed
@brunoabinader brunoabinader deleted the brunoabinader:document-doctype branch Jan 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Implement Document::doctype
4 participants
@brunoabinader @hoppipolla-critic-bot @Ms2ger @bors-servo
You can’t perform that action at this time.