Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustfmt script_traits and net_traits. #14831

Merged
merged 9 commits into from Jan 3, 2017
Merged

Rustfmt script_traits and net_traits. #14831

merged 9 commits into from Jan 3, 2017

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jan 3, 2017 •
edited by larsbergstrom

CC #8553.

This change is Reviewable
Ms2ger added 9 commits Jan 3, 2017
@Ms2ger
Add rustfmt.toml.
b214c3c
@Ms2ger
Simplify ConstellationControlMsg's Debug implementation.
ef13f01
@Ms2ger
Reformat WebDriverScriptCommand::AddCookie.
bf643f5
@Ms2ger
Rustfmt script_traits.
2dde348
@Ms2ger
Use documentation comments for PixelFormat.
410e5c6
@Ms2ger
Reformat fetch_async().
22f85bf
@Ms2ger
Reformat WebSocketNetworkEvent::ConnectionEstablished and CoreResourc…
01114eb 
…eMsg::SetCookieForUrl.
@Ms2ger
Skip rustfmt on to_filtered.
b76613a 
rust-lang/rustfmt#1262
@Ms2ger
Rustfmt net_traits.
Loading status checks…
b46846e
@highfive
Copy link

highfive commented Jan 3, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/script_traits/webdriver_msg.rs, components/script_traits/webdriver_msg.rs, components/script_traits/lib.rs, components/script_traits/lib.rs
  • @KiChjang: components/net_traits/pub_domains.rs, components/net_traits/pub_domains.rs, components/net_traits/request.rs, components/net_traits/request.rs, components/net_traits/image/base.rs, components/net_traits/image/base.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/net_traits/image_cache_thread.rs, components/net_traits/image_cache_thread.rs, components/script_traits/script_msg.rs, components/script_traits/script_msg.rs, components/net_traits/storage_thread.rs, components/net_traits/storage_thread.rs, components/net_traits/response.rs, components/net_traits/response.rs, components/script_traits/webdriver_msg.rs, components/script_traits/webdriver_msg.rs, components/net_traits/filemanager_thread.rs, components/net_traits/filemanager_thread.rs, components/net_traits/hosts.rs, components/net_traits/hosts.rs, components/script_traits/lib.rs, components/script_traits/lib.rs
@highfive
Copy link

highfive commented Jan 3, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@nox
Copy link
Member

nox commented Jan 3, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2017

📌 Commit b46846e has been approved by nox
@highfive highfive assigned nox and unassigned SimonSapin Jan 3, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2017

⌛ Testing commit b46846e with merge 68ecb04...
bors-servo added a commit that referenced this pull request Jan 3, 2017
@bors-servo
Auto merge of #14831 - servo:rustfmt-traits, r=nox
Loading status checks…
68ecb04 
Rustfmt script_traits and net_traits.

CC #8553.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14831)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 3, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-gnu-dev, windows-msvc-dev
@bors-servo bors-servo merged commit b46846e into master Jan 3, 2017
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request
Details
dependency-ci Checking Dependencies
Details
homu Test successful
Details
This was referenced Jan 3, 2017
Merged
Closed
@wafflespeanut wafflespeanut deleted the rustfmt-traits branch Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @highfive @nox @bors-servo @SimonSapin
You can’t perform that action at this time.