New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make offset parent queries less buggy. #14839
Merged
+364
−74
/css-text-3_dev/html/word-break-normal-zh-000.htm fails on Mac
400a267
Select commit
014ad76
Added assertion to process_offset_parent_query
Permutatrix 0a5218d
Fixed ParentOffsetBorderBoxIterator's keeping track of parents
Permutatrix 6623583
offsetParent queries now basically work on inline nodes.
Permutatrix 18793af
Don't crash when offset parent querying an element not in the document
Permutatrix a61a263
Added tests/wpt/web-platform-tests/cssom-view/offsetPropertiesInline.…
Permutatrix 6a76525
Replaced trivial pattern matching with is_none() and is_some()
Permutatrix fa0cb7c
Assert self.node_offset_box is None if fragment.node == self.node_add…
Permutatrix 699fc4b
Use InlineFragmentNodeFlags in ParentOffsetBorderBoxIterator
Permutatrix 923ecba
Updated expectations for passing tests
Permutatrix db5da15
Updated expectations for failing tests that were passing erroneously
Permutatrix 4825169
Split 123-character line
Permutatrix defa7d9
Actually, node_position probably won't be needed later.
Permutatrix b75dcc0
Made assertions more helpful
Permutatrix 5be1879
"above the root node" -> "below the root node"
Permutatrix 290ebab
Moved and adjusted offset_properties_inline test
Permutatrix 5ef7a0a
Don't store the offset parent's dimensions
Permutatrix 686d2f8
Don't use rposition() and unwrap() to find parent info
Permutatrix 74e34d6
Handle hypothetical fragments
Permutatrix cb0d43a
Broke up some comment lines that were a bit too long
Permutatrix af633b2
Use parent padding box, not border box
Permutatrix 2cd5384
Don't take measurements from non-primary fragments
Permutatrix 400a267
/css-text-3_dev/html/word-break-normal-zh-000.htm fails on Mac
Permutatrix
Merged
Make offset parent queries less buggy. #14839
/css-text-3_dev/html/word-break-normal-zh-000.htm fails on Mac
Aug 26, 2016
Aug 30, 2016
Sep 27, 2016
Jan 4, 2017
Jan 4, 2017
Jan 4, 2017
Jan 4, 2017
Jan 5, 2017
Jan 5, 2017
Jan 5, 2017
Jan 5, 2017
Jan 5, 2017
Jan 6, 2017
Jan 6, 2017
Jan 6, 2017
Jan 7, 2017
Jan 7, 2017
Jan 13, 2017
Jan 13, 2017
Jan 13, 2017
Jan 13, 2017
Jan 18, 2017
400a267
Select commit
014ad76
Added assertion to process_offset_parent_query
Permutatrix 0a5218d
Fixed ParentOffsetBorderBoxIterator's keeping track of parents
Permutatrix 6623583
offsetParent queries now basically work on inline nodes.
Permutatrix 18793af
Don't crash when offset parent querying an element not in the document
Permutatrix a61a263
Added tests/wpt/web-platform-tests/cssom-view/offsetPropertiesInline.…
Permutatrix 6a76525
Replaced trivial pattern matching with is_none() and is_some()
Permutatrix fa0cb7c
Assert self.node_offset_box is None if fragment.node == self.node_add…
Permutatrix 699fc4b
Use InlineFragmentNodeFlags in ParentOffsetBorderBoxIterator
Permutatrix 923ecba
Updated expectations for passing tests
Permutatrix db5da15
Updated expectations for failing tests that were passing erroneously
Permutatrix 4825169
Split 123-character line
Permutatrix defa7d9
Actually, node_position probably won't be needed later.
Permutatrix b75dcc0
Made assertions more helpful
Permutatrix 5be1879
"above the root node" -> "below the root node"
Permutatrix 290ebab
Moved and adjusted offset_properties_inline test
Permutatrix 5ef7a0a
Don't store the offset parent's dimensions
Permutatrix 686d2f8
Don't use rposition() and unwrap() to find parent info
Permutatrix 74e34d6
Handle hypothetical fragments
Permutatrix cb0d43a
Broke up some comment lines that were a bit too long
Permutatrix af633b2
Use parent padding box, not border box
Permutatrix 2cd5384
Don't take measurements from non-primary fragments
Permutatrix 400a267
/css-text-3_dev/html/word-break-normal-zh-000.htm fails on Mac
Permutatrix