Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make offset parent queries less buggy. #14839

Merged
merged 22 commits into from Jan 18, 2017
Merged

Make offset parent queries less buggy. #14839

merged 22 commits into from Jan 18, 2017
+364 −74

Commits on Jan 13, 2017

  1. Added assertion to process_offset_parent_query

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    014ad76

  2. Fixed ParentOffsetBorderBoxIterator's keeping track of parents

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    0a5218d

  3. offsetParent queries now basically work on inline nodes.

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    6623583

  4. Don't crash when offset parent querying an element not in the document

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    18793af

  5. Added tests/wpt/web-platform-tests/cssom-view/offsetPropertiesInline.… 

    …html
    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    a61a263

  6. Replaced trivial pattern matching with is_none() and is_some()

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    6a76525

  7. Assert self.node_offset_box is None if fragment.node == self.node_add… 

    …ress
    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    fa0cb7c

  8. Use InlineFragmentNodeFlags in ParentOffsetBorderBoxIterator

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    699fc4b

  9. Updated expectations for passing tests

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    923ecba

  10. Updated expectations for failing tests that were passing erroneously

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    db5da15

  11. Split 123-character line

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    4825169

  12. Actually, node_position probably won't be needed later. 

    This is why you shouldn't make assumptions about what you'll need later!
    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    defa7d9

  13. Made assertions more helpful

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    b75dcc0

  14. "above the root node" -> "below the root node"

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    5be1879

  15. Moved and adjusted offset_properties_inline test

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    290ebab

  16. Don't store the offset parent's dimensions

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    5ef7a0a

  17. Don't use rposition() and unwrap() to find parent info

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    686d2f8

  18. Handle hypothetical fragments

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    74e34d6

  19. Broke up some comment lines that were a bit too long

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    cb0d43a

  20. Use parent padding box, not border box

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    af633b2

  21. Don't take measurements from non-primary fragments

    @Permutatrix
    Permutatrix committed Jan 13, 2017
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    2cd5384

Commits on Jan 18, 2017

  1. /css-text-3_dev/html/word-break-normal-zh-000.htm fails on Mac

    @Permutatrix
    Permutatrix committed Jan 18, 2017
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    Permutatrix Permutator
    GPG key ID: 62D7A8D792C3B058 Learn about signing commits
    400a267
You can’t perform that action at this time.